Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON IDL #5542

Closed
wants to merge 42 commits into from

update idl

2cf54c3
Select commit
Loading
Failed to load commit list.
Closed

JSON IDL #5542

update idl
2cf54c3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2024 in 0s

36.22% (+0.04%) compared to 0da324b

View this Pull Request on Codecov

36.22% (+0.04%) compared to 0da324b

Details

Codecov Report

Attention: Patch coverage is 51.10132% with 111 lines in your changes missing coverage. Please review.

Project coverage is 36.22%. Comparing base (0da324b) to head (2cf54c3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/literals.pb.go 10.37% 95 Missing ⚠️
...opeller/pkg/controller/nodes/attr_path_resolver.go 86.51% 6 Missing and 6 partials ⚠️
flyteidl/clients/go/coreutils/literals.go 84.61% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5542      +/-   ##
==========================================
+ Coverage   36.18%   36.22%   +0.04%     
==========================================
  Files        1302     1302              
  Lines      109666   109819     +153     
==========================================
+ Hits        39678    39787     +109     
- Misses      65841    65876      +35     
- Partials     4147     4156       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov