Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce more generous resource requests and remove duplicate file #5602

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/flyte-binary/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ Chart for basic single Flyte executable deployment
| deployment.podSecurityContext.runAsGroup | int | `65534` | |
| deployment.podSecurityContext.runAsUser | int | `65534` | |
| deployment.readinessProbe | object | `{}` | |
| deployment.resources.requests.cpu | string | `"4"` | |
| deployment.resources.requests.memory | string | `"4Gi"` | |
| deployment.sidecars | list | `[]` | |
| deployment.startupProbe | object | `{}` | |
| deployment.waitForDB.args | list | `[]` | |
Expand Down
123 changes: 0 additions & 123 deletions charts/flyte-binary/eks-production.yaml

This file was deleted.

10 changes: 4 additions & 6 deletions charts/flyte-binary/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,10 @@ deployment:
# lifecycleHooks Specify hooks to run in Flyte container before or after startup
lifecycleHooks: {}
# resources Resource limits and requests for Flyte container
# Uncomment and update to specify resources for deployment
# resources:
# limits:
# memory: 1Gi
# requests:
# cpu: 1
resources:
requests:
cpu: "4"
memory: "4Gi"
# podSecurityContext Specify security context for Flyte pod
# See: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
podSecurityContext:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,10 @@ spec:
echo waiting for database
sleep 0.1
done
resources:
requests:
cpu: "4"
memory: 4Gi
containers:
- name: flyte
image: "cr.flyte.org/flyteorg/flyte-binary:latest"
Expand Down Expand Up @@ -415,6 +419,10 @@ spec:
path: /healthcheck
port: http
initialDelaySeconds: 30
resources:
requests:
cpu: "4"
memory: 4Gi
volumeMounts:
- name: cluster-resource-templates
mountPath: /etc/flyte/cluster-resource-templates
Expand Down
12 changes: 10 additions & 2 deletions docker/sandbox-bundled/manifests/complete-agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: RVJtRHVFeUtzZHdDMjRTQQ==
haSharedSecret: Nmszb2dnV0lvdDV4cTFKRw==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -1289,6 +1289,10 @@ spec:
path: /healthcheck
port: http
initialDelaySeconds: 30
resources:
requests:
cpu: "4"
memory: 4Gi
volumeMounts:
- mountPath: /etc/flyte/cluster-resource-templates
name: cluster-resource-templates
Expand All @@ -1313,6 +1317,10 @@ spec:
image: bitnami/postgresql:sandbox
imagePullPolicy: Never
name: wait-for-db
resources:
requests:
cpu: "4"
memory: 4Gi
serviceAccountName: flyte-sandbox
volumes:
- name: cluster-resource-templates
Expand Down Expand Up @@ -1414,7 +1422,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: b56109123fc8874c06e091766f6e86bd5ffdc4cdc86ea7861092332870babf0e
checksum/secret: e61f7c68a179663c34a4ed4be490c02741a0ee38ef152e5651859418cb4b36bd
labels:
app: docker-registry
release: flyte-sandbox
Expand Down
12 changes: 10 additions & 2 deletions docker/sandbox-bundled/manifests/complete.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: dGZGeUR3THl1ODFKV2ROdA==
haSharedSecret: aEp3U2hKVXdzUmtNQXZzYw==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -1236,6 +1236,10 @@ spec:
path: /healthcheck
port: http
initialDelaySeconds: 30
resources:
requests:
cpu: "4"
memory: 4Gi
volumeMounts:
- mountPath: /etc/flyte/cluster-resource-templates
name: cluster-resource-templates
Expand All @@ -1260,6 +1264,10 @@ spec:
image: bitnami/postgresql:sandbox
imagePullPolicy: Never
name: wait-for-db
resources:
requests:
cpu: "4"
memory: 4Gi
serviceAccountName: flyte-sandbox
volumes:
- name: cluster-resource-templates
Expand Down Expand Up @@ -1361,7 +1369,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: 953e371a21c81445990201881e1603b35558441bea4c3702cc1f3dbdbc66c6b7
checksum/secret: 6a1c2ce15560b5de6ff90d8437ed712de1c3ef32be3420e327d77d3cd0bcfbe2
labels:
app: docker-registry
release: flyte-sandbox
Expand Down
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ metadata:
---
apiVersion: v1
data:
haSharedSecret: clA0NmJsaW9TUHNJYjRYTA==
haSharedSecret: ZlpjYUVxZ3FYMVljSGlCNA==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -934,7 +934,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: 51051b8a95112e2aa1aed0e472540340697cf3481a144444d65dfaa220ae471d
checksum/secret: 23e3effcf66f6c4c67c3b40f34b919e52d7bb808206286c9412673a5b248d44d
labels:
app: docker-registry
release: flyte-sandbox
Expand Down
15 changes: 0 additions & 15 deletions docs/deployment/configuration/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,7 @@
This section will cover how to configure your Flyte cluster for features like
authentication, monitoring, and notifications.

````{important}
The configuration instructions in this section are for the `flyte` and `flyte-core` Helm charts, which is for
the {ref}`multi-cluster setup <deployment-deployment-multicluster>`.

If you're using the `flyte-binary` chart for the {ref}`single cluster setup <deployment-deployment-cloud-simple>`,
instead of specifying configuration under a yaml file like `cloud_events.yaml` in {ref}`deployment-configuration-cloud-event`,
you'll need to add the configuration settings under the `inline` section in the `eks-production.yaml` file:

```{eval-rst}
.. literalinclude:: ../../../charts/flyte-binary/eks-production.yaml
:language: yaml
:lines: 30-41
:caption: charts/flyte-binary/eks-production.yaml
```

````


```{list-table}
Expand Down