Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Fix Union Type Dataclass Ambiguous Error #5627

Closed
wants to merge 1 commit into from

Conversation

Future-Outlier
Copy link
Member

Tracking issue

#5489

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future-Outlier <[email protected]>
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.29%. Comparing base (1124ea9) to head (6abef55).
Report is 221 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1124ea9) and HEAD (6abef55). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (1124ea9) HEAD (6abef55)
unittests-flyteadmin 1 0
unittests-flytectl 1 0
unittests-flytepropeller 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5627       +/-   ##
===========================================
- Coverage   36.17%   24.29%   -11.89%     
===========================================
  Files        1302      529      -773     
  Lines      109417    58426    -50991     
===========================================
- Hits        39587    14196    -25391     
+ Misses      65694    42852    -22842     
+ Partials     4136     1378     -2758     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin ?
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl ?
unittests-flyteidl 7.09% <ø> (ø)
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller ?
unittests-flytestdlib 55.33% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant