-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flytepropeller][flyteadmin] Compiler unknown literal type error handling #5651
[flytepropeller][flyteadmin] Compiler unknown literal type error handling #5651
Conversation
Signed-off-by: Future-Outlier <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5651 +/- ##
==========================================
+ Coverage 36.30% 36.31% +0.01%
==========================================
Files 1305 1305
Lines 110002 110051 +49
==========================================
+ Hits 39932 39964 +32
- Misses 65914 65932 +18
+ Partials 4156 4155 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Hi, @eapolinario |
Why are the changes needed?
To avoid a crash when a new IDL type is sent to the propeller or admin.
What changes were proposed in this pull request?
Add error handling and prevent crashes in these sections of the code.
How was this patch tested?
most unit tests, and 1 Python example in the comments below.
Setup process
flyteidl:
pip install git+https://github.com/flyteorg/flyte.git@2c9cbd89dce53acd1cb90cc042012637ae6c31f8#subdirectory=flyteidl
flytekit: flyteorg/flytekit#2741
python example:
Screenshots
Check all the applicable boxes
Related PRs
#5612