Validate labels before creating flyte CRD #5671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5671 +/- ##
==========================================
+ Coverage 35.90% 36.17% +0.27%
==========================================
Files 1301 1302 +1
Lines 109401 109494 +93
==========================================
+ Hits 39275 39611 +336
+ Misses 66029 65745 -284
- Partials 4097 4138 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Admin created the flyte CRD three times when using invalid labels in the execution and showed the error in flyteconsole.
We should validate labels before creating a CRD and return the error message to the client side (flytekit).
What changes were proposed in this pull request?
Validate labels before creating flyte CRD.
How was this patch tested?
Setup process
Screenshots
Before:
After:
Check all the applicable boxes
Related PRs
NA
Docs link
NA