[flytectl] DataConfig missing from TaskSpec #5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5692 +/- ##
==========================================
- Coverage 36.18% 36.18% -0.01%
==========================================
Files 1302 1302
Lines 109613 109614 +1
==========================================
- Hits 39662 39660 -2
- Misses 65806 65809 +3
Partials 4145 4145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pingsutw
approved these changes
Aug 24, 2024
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
bgedik
pushed a commit
to bgedik/flyte
that referenced
this pull request
Sep 12, 2024
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Slack reported issue.
Why are the changes needed?
When hydrating the taskspec, the DataLoadingConfig is missing for K8s pod.
What changes were proposed in this pull request?
Add the field.
How was this patch tested?
tested by packaging and registering against development cluster.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link