Using new offloaded metadata literal message for literal offloading #5705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmahindrakar-oss
requested review from
katrogan,
eapolinario,
wild-endeavor and
hamersaw
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5705 +/- ##
==========================================
- Coverage 36.18% 36.16% -0.02%
==========================================
Files 1302 1302
Lines 109614 109653 +39
==========================================
+ Hits 39660 39661 +1
- Misses 65809 65847 +38
Partials 4145 4145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
katrogan
previously approved these changes
Aug 29, 2024
eapolinario
reviewed
Aug 29, 2024
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
pmahindrakar-oss
force-pushed
the
offloaded-literal-updated-idl
branch
from
5ac8266 to
8de47b1
Compare
wild-endeavor
approved these changes
Aug 29, 2024
pingsutw
approved these changes
Aug 29, 2024
pmahindrakar-oss
added a commit
that referenced
this pull request
Sep 9, 2024
bgedik
pushed a commit
to bgedik/flyte
that referenced
this pull request
Sep 12, 2024
…lyteorg#5705) Signed-off-by: Bugra Gedik <[email protected]>
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
RFC #5103
Why are the changes needed?
Without these changes we hit grpc limit when propeller tries to create an execution by passing inputs inline which it got from output of large map task
What changes were proposed in this pull request?
Adding a new sub message for offloaded literal which would be populated initially by propeller for map task user when the collected values are greater than configured threshold and later flytekit which write the o/p where we will be adding similar checks
How was this patch tested?
Will be tested as part of this PR #5697
These are just IDL changes
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link