Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IsDefault to False for echo plugin #5713

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

pingsutw
Copy link
Member

Tracking issue

NA

Why are the changes needed?

If IsDefault is True, the unknown task will always be handled by the echo plugin and always succeed.

{"json":{"exec_id":"fd2ed7347cfdb4e338f2","node":"n0","ns":"kk-flyte-dev3","res_ver":"9901776719","routine":"worker-
0","src":"handler.go:340","tasktype":"gnn","wf":"shuliang-
projects:development:gnn_agent_test.wf"},"level":"warning","msg":"No plugin found for Handler-type [gnn], defaulting to 
[echo]","ts":"2024-08-31T05:51:07Z"}

What changes were proposed in this pull request?

Set IsDefault to false

How was this patch tested?

single binary

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.16%. Comparing base (7a91799) to head (38f0380).
Report is 153 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5713      +/-   ##
==========================================
- Coverage   36.17%   36.16%   -0.01%     
==========================================
  Files        1303     1303              
  Lines      109663   109663              
==========================================
- Hits        39667    39660       -7     
- Misses      65851    65858       +7     
  Partials     4145     4145              
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.25% <ø> (-0.04%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.18% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.34% <ø> (ø)
unittests-flytepropeller 41.76% <ø> (ø)
unittests-flytestdlib 55.33% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier
Copy link
Member

I've checked the code, let's merge it.
image

@Future-Outlier Future-Outlier merged commit 79a1e46 into master Sep 2, 2024
50 checks passed
@Future-Outlier Future-Outlier deleted the echo-not-default branch September 2, 2024 01:30
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
bgedik pushed a commit to bgedik/flyte that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants