Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] JSON IDL V2 #5735

Closed
wants to merge 4 commits into from
Closed

[wip] JSON IDL V2 #5735

wants to merge 4 commits into from

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Sep 10, 2024

Flytekit

flyteorg/flytekit#2741

Tracking issue

#5318

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title JSON IDL V2 [wip] JSON IDL V2 Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 4.81928% with 158 lines in your changes missing coverage. Please review.

Project coverage is 36.18%. Comparing base (89efcc6) to head (dd21c31).
Report is 163 commits behind head on master.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/literals.pb.go 4.54% 105 Missing ⚠️
...opeller/pkg/controller/nodes/attr_path_resolver.go 5.76% 47 Missing and 2 partials ⚠️
flytepropeller/pkg/compiler/validators/typing.go 0.00% 1 Missing and 1 partial ⚠️
flytepropeller/pkg/compiler/validators/utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5735      +/-   ##
==========================================
- Coverage   36.21%   36.18%   -0.04%     
==========================================
  Files        1303     1303              
  Lines      109568   109663      +95     
==========================================
  Hits        39683    39683              
- Misses      65764    65857      +93     
- Partials     4121     4123       +2     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.63% <ø> (+0.01%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.11% <4.54%> (-0.01%) ⬇️
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.66% <5.35%> (-0.10%) ⬇️
unittests-flytestdlib 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant