Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listing api to stow storage #5741

Merged

Conversation

bgedik
Copy link
Contributor

@bgedik bgedik commented Sep 12, 2024

Tracking issue

Part of RFC https://github.com/flyteorg/flyte/blob/b3add894fd879d6b6c11e37ba292ae04bf60afeb/rfc/system/5598-deterministic-errors-distributed-training.md#flytepropeller-backend

Why are the changes needed?

Deterministic error propagation, see: https://github.com/flyteorg/flyte/blob/b3add894fd879d6b6c11e37ba292ae04bf60afeb/rfc/system/5598-deterministic-errors-distributed-training.md#flytepropeller-backend

What changes were proposed in this pull request?

Adding listing APIs

How was this patch tested?

Unit tests

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#5616

Docs link

N/A

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 43.42105% with 43 lines in your changes missing coverage. Please review.

Project coverage is 36.22%. Comparing base (86c63f7) to head (2793f69).
Report is 158 commits behind head on master.

Files with missing lines Patch % Lines
...ytestdlib/storage/mocks/composed_protobuf_store.go 0.00% 27 Missing ⚠️
flytestdlib/storage/stow_store.go 67.74% 6 Missing and 4 partials ⚠️
flyteadmin/pkg/common/mocks/storage.go 0.00% 2 Missing ⚠️
flytepropeller/pkg/utils/failing_datastore.go 0.00% 2 Missing ⚠️
flytestdlib/storage/mem_store.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5741   +/-   ##
=======================================
  Coverage   36.21%   36.22%           
=======================================
  Files        1303     1303           
  Lines      109568   109644   +76     
=======================================
+ Hits        39683    39719   +36     
- Misses      65765    65801   +36     
- Partials     4120     4124    +4     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.63% <0.00%> (-0.01%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.26% <ø> (+0.04%) ⬆️
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.75% <0.00%> (-0.01%) ⬇️
unittests-flytestdlib 55.21% <45.83%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wild-endeavor
wild-endeavor previously approved these changes Sep 12, 2024
@bgedik bgedik mentioned this pull request Sep 12, 2024
3 tasks
@wild-endeavor wild-endeavor merged commit e67aae0 into flyteorg:master Sep 12, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants