Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add css styling #5803

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

cosmicBboy
Copy link
Contributor

This ports over a bunch of styles from docs.union.ai so that the appearance is more similar

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.32%. Comparing base (0198e91) to head (c920121).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           nielsb/docs-overhaul-flyteidl    #5803   +/-   ##
==============================================================
  Coverage                          36.31%   36.32%           
==============================================================
  Files                               1304     1304           
  Lines                             110072   110048   -24     
==============================================================
- Hits                               39971    39970    -1     
+ Misses                             65939    65922   -17     
+ Partials                            4162     4156    -6     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.61% <ø> (+0.04%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.12% <ø> (-0.01%) ⬇️
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.93% <ø> (+0.01%) ⬆️
unittests-flytestdlib 55.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
@cosmicBboy cosmicBboy merged commit efca412 into nielsb/docs-overhaul-flyteidl Oct 3, 2024
47 of 49 checks passed
@cosmicBboy cosmicBboy deleted the nielsb/css-styling branch October 3, 2024 20:39
cosmicBboy added a commit that referenced this pull request Oct 3, 2024
* fix flyteidl structure so it renders under /api/

Signed-off-by: Niels Bantilan <[email protected]>

* do not check in flyteidl docs

Signed-off-by: Niels Bantilan <[email protected]>

* update gitignore and unneeded conf

Signed-off-by: Niels Bantilan <[email protected]>

* add mock DOCSEARCH_API_KEY to docs test ci

Signed-off-by: Niels Bantilan <[email protected]>

* add css styling (#5803)

* add css styling

Signed-off-by: Niels Bantilan <[email protected]>

* update logo height

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>
eapolinario pushed a commit that referenced this pull request Oct 4, 2024
* move flytekit and flytectl docs into API section

Signed-off-by: nikki everett <[email protected]>

* switch to docsearch module and env variables

Signed-off-by: nikki everett <[email protected]>

* reorganize content for pydata theme

Signed-off-by: nikki everett <[email protected]>

* more docs reorganization

Signed-off-by: nikki everett <[email protected]>

* switch to pydata theme

Signed-off-by: nikki everett <[email protected]>

* reorganize concepts/glossary and ecosystem docs

Signed-off-by: nikki everett <[email protected]>

* remove unneeded custom CSS and JS files

Signed-off-by: nikki everett <[email protected]>

* add redirects

Signed-off-by: nikki everett <[email protected]>

* add more redirects

Signed-off-by: nikki everett <[email protected]>

* first pass at updating docs contributing guide

Signed-off-by: nikki everett <[email protected]>

* remove core use cases

Signed-off-by: nikki everett <[email protected]>

* more edits to docs contributing guide

Signed-off-by: nikki everett <[email protected]>

* more edits to the flytesnacks contributing guide

Signed-off-by: nikki everett <[email protected]>

* add content to API reference index page, use consistent title and format for API reference section titles

Signed-off-by: nikki everett <[email protected]>

* rename deployment section

Signed-off-by: nikki everett <[email protected]>

* reorganize sections

Signed-off-by: nikki everett <[email protected]>

* fix typos

Signed-off-by: nikki everett <[email protected]>

* add docsearch index name and app id

Signed-off-by: nikki everett <[email protected]>

* add ref to docs contributing doc and move all docsearch stuff to env vars again

Signed-off-by: nikki everett <[email protected]>

* docs overhaul: render flyteidl under the /api/ path (#5802)

* fix flyteidl structure so it renders under /api/

Signed-off-by: Niels Bantilan <[email protected]>

* do not check in flyteidl docs

Signed-off-by: Niels Bantilan <[email protected]>

* update gitignore and unneeded conf

Signed-off-by: Niels Bantilan <[email protected]>

* add mock DOCSEARCH_API_KEY to docs test ci

Signed-off-by: Niels Bantilan <[email protected]>

* add css styling (#5803)

* add css styling

Signed-off-by: Niels Bantilan <[email protected]>

* update logo height

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>

* use same icon as union docs

Signed-off-by: nikki everett <[email protected]>

* sp error

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Co-authored-by: Niels Bantilan <[email protected]>
siiddhantt pushed a commit to siiddhantt/flyte that referenced this pull request Oct 7, 2024
* move flytekit and flytectl docs into API section

Signed-off-by: nikki everett <[email protected]>

* switch to docsearch module and env variables

Signed-off-by: nikki everett <[email protected]>

* reorganize content for pydata theme

Signed-off-by: nikki everett <[email protected]>

* more docs reorganization

Signed-off-by: nikki everett <[email protected]>

* switch to pydata theme

Signed-off-by: nikki everett <[email protected]>

* reorganize concepts/glossary and ecosystem docs

Signed-off-by: nikki everett <[email protected]>

* remove unneeded custom CSS and JS files

Signed-off-by: nikki everett <[email protected]>

* add redirects

Signed-off-by: nikki everett <[email protected]>

* add more redirects

Signed-off-by: nikki everett <[email protected]>

* first pass at updating docs contributing guide

Signed-off-by: nikki everett <[email protected]>

* remove core use cases

Signed-off-by: nikki everett <[email protected]>

* more edits to docs contributing guide

Signed-off-by: nikki everett <[email protected]>

* more edits to the flytesnacks contributing guide

Signed-off-by: nikki everett <[email protected]>

* add content to API reference index page, use consistent title and format for API reference section titles

Signed-off-by: nikki everett <[email protected]>

* rename deployment section

Signed-off-by: nikki everett <[email protected]>

* reorganize sections

Signed-off-by: nikki everett <[email protected]>

* fix typos

Signed-off-by: nikki everett <[email protected]>

* add docsearch index name and app id

Signed-off-by: nikki everett <[email protected]>

* add ref to docs contributing doc and move all docsearch stuff to env vars again

Signed-off-by: nikki everett <[email protected]>

* docs overhaul: render flyteidl under the /api/ path (flyteorg#5802)

* fix flyteidl structure so it renders under /api/

Signed-off-by: Niels Bantilan <[email protected]>

* do not check in flyteidl docs

Signed-off-by: Niels Bantilan <[email protected]>

* update gitignore and unneeded conf

Signed-off-by: Niels Bantilan <[email protected]>

* add mock DOCSEARCH_API_KEY to docs test ci

Signed-off-by: Niels Bantilan <[email protected]>

* add css styling (flyteorg#5803)

* add css styling

Signed-off-by: Niels Bantilan <[email protected]>

* update logo height

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>

* use same icon as union docs

Signed-off-by: nikki everett <[email protected]>

* sp error

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Co-authored-by: Niels Bantilan <[email protected]>
Signed-off-by: Siddhant Rai <[email protected]>
davidmirror-ops pushed a commit that referenced this pull request Oct 31, 2024
* Update registering_workflows.md

Signed-off-by: Siddhant Rai <[email protected]>

* feat: note in registering_workflows for k8sPod.dataConfig fix

Signed-off-by: Siddhant Rai <[email protected]>

* update: remove note as requested change

Signed-off-by: Siddhant Rai <[email protected]>
Signed-off-by: Siddhant Rai <[email protected]>

* Flyte docs overhaul (phase 1) (#5772)

* move flytekit and flytectl docs into API section

Signed-off-by: nikki everett <[email protected]>

* switch to docsearch module and env variables

Signed-off-by: nikki everett <[email protected]>

* reorganize content for pydata theme

Signed-off-by: nikki everett <[email protected]>

* more docs reorganization

Signed-off-by: nikki everett <[email protected]>

* switch to pydata theme

Signed-off-by: nikki everett <[email protected]>

* reorganize concepts/glossary and ecosystem docs

Signed-off-by: nikki everett <[email protected]>

* remove unneeded custom CSS and JS files

Signed-off-by: nikki everett <[email protected]>

* add redirects

Signed-off-by: nikki everett <[email protected]>

* add more redirects

Signed-off-by: nikki everett <[email protected]>

* first pass at updating docs contributing guide

Signed-off-by: nikki everett <[email protected]>

* remove core use cases

Signed-off-by: nikki everett <[email protected]>

* more edits to docs contributing guide

Signed-off-by: nikki everett <[email protected]>

* more edits to the flytesnacks contributing guide

Signed-off-by: nikki everett <[email protected]>

* add content to API reference index page, use consistent title and format for API reference section titles

Signed-off-by: nikki everett <[email protected]>

* rename deployment section

Signed-off-by: nikki everett <[email protected]>

* reorganize sections

Signed-off-by: nikki everett <[email protected]>

* fix typos

Signed-off-by: nikki everett <[email protected]>

* add docsearch index name and app id

Signed-off-by: nikki everett <[email protected]>

* add ref to docs contributing doc and move all docsearch stuff to env vars again

Signed-off-by: nikki everett <[email protected]>

* docs overhaul: render flyteidl under the /api/ path (#5802)

* fix flyteidl structure so it renders under /api/

Signed-off-by: Niels Bantilan <[email protected]>

* do not check in flyteidl docs

Signed-off-by: Niels Bantilan <[email protected]>

* update gitignore and unneeded conf

Signed-off-by: Niels Bantilan <[email protected]>

* add mock DOCSEARCH_API_KEY to docs test ci

Signed-off-by: Niels Bantilan <[email protected]>

* add css styling (#5803)

* add css styling

Signed-off-by: Niels Bantilan <[email protected]>

* update logo height

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>

* use same icon as union docs

Signed-off-by: nikki everett <[email protected]>

* sp error

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Co-authored-by: Niels Bantilan <[email protected]>
Signed-off-by: Siddhant Rai <[email protected]>

* [Flyte][3][flytepropeller][Attribute Access][flytectl] Binary IDL With MessagePack (#5763)

Signed-off-by: Siddhant Rai <[email protected]>

* Update aws-go-sdk to v1.47.11 to support EKS Pod Identity (#5796)

Signed-off-by: Siddhant Rai <[email protected]>

* Update docs/user_guide/flyte_fundamentals/registering_workflows.md

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Siddhant Rai <[email protected]>

* Update registering_workflows.md

Signed-off-by: Siddhant Rai <[email protected]>

---------

Signed-off-by: Siddhant Rai <[email protected]>
Signed-off-by: Siddhant Rai <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Co-authored-by: Nikki Everett <[email protected]>
Co-authored-by: Niels Bantilan <[email protected]>
Co-authored-by: Future-Outlier <[email protected]>
Co-authored-by: mthemis-provenir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants