Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #5839

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

initial commit #5839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 56 additions & 3 deletions docs/deployment/plugins/k8s/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,20 @@ Specify plugin configuration
- kind: ServiceAccount
name: spark
namespace: "{{ namespace }}"

rbac:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rbac:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aazam-gh Please remove this whole section as it belongs to Spark config, which is not the focus of the issue

create: true
extraRules:
- apiGroups:
- "ray.io"
resources:
- rayjobs
verbs:
- create
- get
- list
- patch
- update
- delete
2. (Optional) The Spark operator supports Kubernetes ResourceQuota enforcement. If you plan to use it,
set `per-Task resource requests <https://docs.flyte.org/en/latest/user_guide/productionizing/customizing_task_resources.html#customizing-task-resources>`__ that fit into the quota for each project-namespace. A Task without resource requests
or limits will be rejected by the K8s scheduler as described `in the Kubernetes docs <https://kubernetes.io/docs/concepts/policy/resource-quotas/>`__.
Expand Down Expand Up @@ -595,7 +608,20 @@ Specify plugin configuration
- kind: ServiceAccount
name: spark
namespace: "{{ namespace }}"

rbac:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rbac:

Same here, this section is not Ray but Spark. Please remove

create: true
extraRules:
- apiGroups:
- "ray.io"
resources:
- rayjobs
verbs:
- create
- get
- list
- patch
- update
- delete
.. group-tab:: flyte-core

.. tabs::
Expand Down Expand Up @@ -687,7 +713,20 @@ Specify plugin configuration
- kind: ServiceAccount
name: spark
namespace: {{ namespace }}

rbac:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rbac:

create: true
extraRules:
- apiGroups:
- "ray.io"
resources:
- rayjobs
verbs:
- create
- get
- list
- patch
- update
- delete
sparkoperator:
enabled: true
plugin_config:
Expand Down Expand Up @@ -748,6 +787,20 @@ Specify plugin configuration
- development:
- gsa:
value: "<GoogleServiceAccount-email>"
rbac:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rbac:

create: true
extraRules:
- apiGroups:
- "ray.io"
resources:
- rayjobs
verbs:
- create
- get
- list
- patch
- update
- delete
templates:
# -- Template for namespaces resources
- key: aa_namespace
Expand Down
Loading