Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for monitoring docs YAML #5917

Merged

Conversation

davidmirror-ops
Copy link
Contributor

Fixes a couple of indented lines that shouldn't be part of the code block

Signed-off-by: davidmirror-ops <[email protected]>
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.84%. Comparing base (1279740) to head (c366f0c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5917      +/-   ##
==========================================
+ Coverage   36.53%   36.84%   +0.31%     
==========================================
  Files        1249     1309      +60     
  Lines      128230   130967    +2737     
==========================================
+ Hits        46847    48259    +1412     
- Misses      77346    78524    +1178     
- Partials     4037     4184     +147     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (?)
unittests-flyteadmin 54.14% <ø> (ø)
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.64% <ø> (ø)
unittests-flytepropeller 43.00% <ø> (ø)
unittests-flytestdlib 55.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops merged commit 13b3d82 into flyteorg:master Oct 25, 2024
51 checks passed
peterghaddad pushed a commit to lmco/flyte that referenced this pull request Oct 28, 2024
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: e356161 <[email protected]>
eapolinario pushed a commit that referenced this pull request Nov 11, 2024
* Fix YAML (#5917)

Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: e356161 <[email protected]>

* make change

Signed-off-by: e356161 <[email protected]>

* update tests

Signed-off-by: e356161 <[email protected]>

* revert change

---------

Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: e356161 <[email protected]>
Co-authored-by: David Espejo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant