-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve literal type string representation handling #5932
Conversation
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5932 +/- ##
==========================================
- Coverage 36.84% 36.82% -0.03%
==========================================
Files 1309 1310 +1
Lines 130967 130979 +12
==========================================
- Hits 48252 48229 -23
- Misses 78531 78572 +41
+ Partials 4184 4178 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Dependency ReviewThe following issues were found:
|
Signed-off-by: Kevin Su <[email protected]>
This reverts commit dd43659.
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, and it's backward compatible (really happy about this).
Tell me when you want to merge it (need to fix lint error)
Signed-off-by: Kevin Su <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice PR, thank you
Tracking issue
NA
Why are the changes needed?
Printing the JSON schema in the error message is not helpful, and sometimes the error message becomes too large when using a large dataclass
What changes were proposed in this pull request?
Add a
LiteralTypeToStr
function to convertLiteralType
to string. It will remove the metadata from Literal Type if the type isSimple.Struct
.How was this patch tested?
Setup process
Screenshots
Before:
After:
Check all the applicable boxes
Related PRs
Docs link