-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed [Docs] Spot/interruptible docs imply retries come from the user… Closes #3956 #5938
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
… retry budget flyteorg#3956 Signed-off-by: Anirban Pal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5938 +/- ##
==========================================
- Coverage 36.84% 36.84% -0.01%
==========================================
Files 1309 1309
Lines 130967 130994 +27
==========================================
+ Hits 48259 48268 +9
- Misses 78524 78536 +12
- Partials 4184 4190 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
64867b2
to
982067b
Compare
Signed-off-by: Anirban Pal <[email protected]>
Signed-off-by: Anirban Pal <[email protected]>
I am waiting for workflow approval from maintainers @davidmirror-ops . Thanks! |
Next time you can also install requirements and build locally with make -c html to catch syntax errors |
@davidmirror-ops As i have updated the syntax of the docs ....unit test flytectl failing has no relation to my commit.this test failure might be: A flaky test help me out please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Congrats on merging your first pull request! 🎉 |
@davidmirror-ops thank you |
… retry budget #3956
What changes were proposed in this pull request?
This PR clarifies the documentation regarding retry behavior for interruptible tasks in Flyte. It updates sections to emphasize that retries for spot/interruptible instances utilize the system retry budget rather than the user-specified retry budget. Changes are made in the user guide and related documentation files to ensure accurate guidance for users managing task retries on preemptible compute resources.