Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Add logger for compiler and marshal while comparing union #6034

Merged
merged 34 commits into from
Nov 20, 2024
Merged

[Fix] Add logger for compiler and marshal while comparing union #6034

merged 34 commits into from
Nov 20, 2024

Conversation

mao3267
Copy link
Contributor

@mao3267 mao3267 commented Nov 20, 2024 •
edited
Loading

Tracking issue

Related to #5489

Why are the changes needed?

  1. To show logs for users to debug more easily.

What changes were proposed in this pull request?

  1. Add logger info for compiler and json marshaling

How was this patch tested?

None

Screenshots

None

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#5858

Docs link

None

mao3267 and others added 30 commits October 18, 2024 13:08
@mao3267
feat: fix Union type with dataclass ambiguous error
f06cdc6 
Signed-off-by: mao3267 <[email protected]>
@mao3267
Merge branch 'master' of https://github.com/mao3267/flyte into fix/fl…
8660db5 
…yteorg#5489-dataclass-mismatch

Signed-off-by: mao3267 <[email protected]>
@mao3267
fix: direct json comparison for superset
47ccbd1 
Signed-off-by: mao3267 <[email protected]>
@mao3267
fix: go.mod missing entry for error
85489dc 
Signed-off-by: mao3267 <[email protected]>
@mao3267
fix: update go module and sum
cc685bb 
Signed-off-by: mao3267 <[email protected]>
@mao3267
refactor: gci format
3a629e1 
Signed-off-by: mao3267 <[email protected]>
@mao3267
test: add dataset casting tests for same (one/two levels) and superse…
aa4d98e 
…t (one level) dataclass

Signed-off-by: mao3267 <[email protected]>
@mao3267
Merge branch 'master' of https://github.com/mao3267/flyte into fix/fl…
b282e5f 
…yteorg#5489-dataclass-mismatch
@mao3267
fix: support Pydantic BaseModel comparison
818afb7 
Signed-off-by: mao3267 <[email protected]>
@mao3267
fix: handle nested pydantic basemodel
d6468b6 
Signed-off-by: mao3267 <[email protected]>
@Future-Outlier
Reviews from Eduardo
ada05ed 
Signed-off-by: Future-Outlier <[email protected]>
@mao3267
fix: support strict subset match
56623e3 
Signed-off-by: mao3267 <[email protected]>
@mao3267
test: update strict subset match test
b8f38a7 
Signed-off-by: mao3267 <[email protected]>
@mao3267
fix: missing go mod entry
b698769 
Signed-off-by: mao3267 <[email protected]>
@mao3267
fix: missing go mod entry
70ad767 
Signed-off-by: mao3267 <[email protected]>
@mao3267
fix: go mod entry
9dc3fa6 
Signed-off-by: mao3267 <[email protected]>
@Future-Outlier
make go-tidy
b224a02 
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier
comments
7ed9be2 
Signed-off-by: Future-Outlier <[email protected]>
@mao3267
Merge branch 'fix/flyteorg#5489-dataclass-mismatch' of https://github…
6fe8871 
….com/mao3267/flyte into fix/flyteorg#5489-dataclass-mismatch
@mao3267
fix: strict subset match with draft 2020-12 mashumaro
64343c8 
Signed-off-by: mao3267 <[email protected]>
@mao3267
Merge branch 'master' of https://github.com/mao3267/flyte into fix/fl…
8ccced5 
…yteorg#5489-dataclass-mismatch
@mao3267
refactor: make go-tidy
0def0ad 
Signed-off-by: mao3267 <[email protected]>
@mao3267
fix: support strict subset match with ambiguity
81445a7 
Signed-off-by: mao3267 <[email protected]>
@mao3267
fix: change test name and fix err
9b19f04 
Signed-off-by: mao3267 <[email protected]>
@Future-Outlier
Add comments
30aa096 
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier
nit
e62ba6e 
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier
add flytectl go-tidy in makefile
c6ac729 
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier
nit
ba4d6f1 
Signed-off-by: Future-Outlier <[email protected]>
@mao3267
fix: add comment for error checking
86a395e 
Signed-off-by: mao3267 <[email protected]>
@mao3267
test: basemodel castable test, two level dataclass and ParentToChild …
7f28c35 
…failure

Signed-off-by: mao3267 <[email protected]>
@mao3267
Copy link
Contributor Author

mao3267 commented Nov 20, 2024

Quick fix for #5858 after merging.
cc @Future-Outlier

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 19.23077% with 21 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (47edd99) to head (1f92e5c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
flytepropeller/pkg/compiler/validators/typing.go 19.23% 17 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6034      +/-   ##
==========================================
- Coverage   37.07%   37.07%   -0.01%     
==========================================
  Files        1316     1316              
  Lines      132176   132191      +15     
==========================================
- Hits        49010    49007       -3     
- Misses      78908    78922      +14     
- Partials     4258     4262       +4
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (ø)
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.46% <ø> (ø)
unittests-flyteidl 7.25% <ø> (ø)
unittests-flyteplugins 53.72% <ø> (ø)
unittests-flytepropeller 42.65% <19.23%> (-0.04%) ⬇️
unittests-flytestdlib 57.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@Future-Outlier
better error msg format
1f92e5c 
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier enabled auto-merge (squash) November 20, 2024 04:58
@Future-Outlier Future-Outlier merged commit bee83e5 into flyteorg:master Nov 20, 2024
51 of 52 checks passed
SZL741023 pushed a commit to SZL741023/flyte that referenced this pull request Nov 20, 2024
@mao3267 @Future-Outlier @SZL741023
[Fix] Add logger for compiler and marshal while comparing union (flyt…
b04cba3 
…eorg#6034)

* feat: fix Union type with dataclass ambiguous error

Signed-off-by: mao3267 <[email protected]>

* fix: direct json comparison for superset

Signed-off-by: mao3267 <[email protected]>

* fix: go.mod missing entry for error

Signed-off-by: mao3267 <[email protected]>

* fix: update go module and sum

Signed-off-by: mao3267 <[email protected]>

* refactor: gci format

Signed-off-by: mao3267 <[email protected]>

* test: add dataset casting tests for same  (one/two levels) and superset (one level) dataclass

Signed-off-by: mao3267 <[email protected]>

* fix: support Pydantic BaseModel comparison

Signed-off-by: mao3267 <[email protected]>

* fix: handle nested pydantic basemodel

Signed-off-by: mao3267 <[email protected]>

* Reviews from Eduardo

Signed-off-by: Future-Outlier <[email protected]>

* fix: support strict subset match

Signed-off-by: mao3267 <[email protected]>

* test: update strict subset match test

Signed-off-by: mao3267 <[email protected]>

* fix: missing go mod entry

Signed-off-by: mao3267 <[email protected]>

* fix: missing go mod entry

Signed-off-by: mao3267 <[email protected]>

* fix: go mod entry

Signed-off-by: mao3267 <[email protected]>

* make go-tidy

Signed-off-by: Future-Outlier <[email protected]>

* comments

Signed-off-by: Future-Outlier <[email protected]>

* fix: strict subset match with draft 2020-12 mashumaro

Signed-off-by: mao3267 <[email protected]>

* refactor: make go-tidy

Signed-off-by: mao3267 <[email protected]>

* fix: support strict subset match with ambiguity

Signed-off-by: mao3267 <[email protected]>

* fix: change test name and fix err

Signed-off-by: mao3267 <[email protected]>

* Add comments

Signed-off-by: Future-Outlier <[email protected]>

* nit

Signed-off-by: Future-Outlier <[email protected]>

* add flytectl go-tidy in makefile

Signed-off-by: Future-Outlier <[email protected]>

* nit

Signed-off-by: Future-Outlier <[email protected]>

* fix: add comment for error checking

Signed-off-by: mao3267 <[email protected]>

* test: basemodel castable test, two level dataclass and ParentToChild failure

Signed-off-by: mao3267 <[email protected]>

* fix: add logger for jsonschema compiler

Signed-off-by: mao3267 <[email protected]>

* fix: add logger for marshal and compiler

Signed-off-by: mao3267 <[email protected]>

* better error msg format

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: mao3267 <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Future-Outlier <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
Future-Outlier added a commit that referenced this pull request Nov 28, 2024
@SZL741023 @mao3267 @Future-Outlier
[Docs][flyteagent] Added description of exception deletion cases. (#6039
b2759fc 
)

* [Fix] Add logger for compiler and marshal while comparing union (#6034)

* feat: fix Union type with dataclass ambiguous error

Signed-off-by: mao3267 <[email protected]>

* fix: direct json comparison for superset

Signed-off-by: mao3267 <[email protected]>

* fix: go.mod missing entry for error

Signed-off-by: mao3267 <[email protected]>

* fix: update go module and sum

Signed-off-by: mao3267 <[email protected]>

* refactor: gci format

Signed-off-by: mao3267 <[email protected]>

* test: add dataset casting tests for same  (one/two levels) and superset (one level) dataclass

Signed-off-by: mao3267 <[email protected]>

* fix: support Pydantic BaseModel comparison

Signed-off-by: mao3267 <[email protected]>

* fix: handle nested pydantic basemodel

Signed-off-by: mao3267 <[email protected]>

* Reviews from Eduardo

Signed-off-by: Future-Outlier <[email protected]>

* fix: support strict subset match

Signed-off-by: mao3267 <[email protected]>

* test: update strict subset match test

Signed-off-by: mao3267 <[email protected]>

* fix: missing go mod entry

Signed-off-by: mao3267 <[email protected]>

* fix: missing go mod entry

Signed-off-by: mao3267 <[email protected]>

* fix: go mod entry

Signed-off-by: mao3267 <[email protected]>

* make go-tidy

Signed-off-by: Future-Outlier <[email protected]>

* comments

Signed-off-by: Future-Outlier <[email protected]>

* fix: strict subset match with draft 2020-12 mashumaro

Signed-off-by: mao3267 <[email protected]>

* refactor: make go-tidy

Signed-off-by: mao3267 <[email protected]>

* fix: support strict subset match with ambiguity

Signed-off-by: mao3267 <[email protected]>

* fix: change test name and fix err

Signed-off-by: mao3267 <[email protected]>

* Add comments

Signed-off-by: Future-Outlier <[email protected]>

* nit

Signed-off-by: Future-Outlier <[email protected]>

* add flytectl go-tidy in makefile

Signed-off-by: Future-Outlier <[email protected]>

* nit

Signed-off-by: Future-Outlier <[email protected]>

* fix: add comment for error checking

Signed-off-by: mao3267 <[email protected]>

* test: basemodel castable test, two level dataclass and ParentToChild failure

Signed-off-by: mao3267 <[email protected]>

* fix: add logger for jsonschema compiler

Signed-off-by: mao3267 <[email protected]>

* fix: add logger for marshal and compiler

Signed-off-by: mao3267 <[email protected]>

* better error msg format

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: mao3267 <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Co-authored-by: Future-Outlier <[email protected]>
Signed-off-by: SZL741023 <[email protected]>

* [Docs] Add Async agent create job process and exception delete cas.

Signed-off-by: SZL741023 <[email protected]>

* update

Signed-off-by: Future-Outlier <[email protected]>

* grammar update

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: mao3267 <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
Co-authored-by: Vincent Chen <[email protected]>
Co-authored-by: Future-Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Future-Outlier Future-Outlier Future-Outlier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mao3267 @Future-Outlier