[copilot] rename sidecar to uploader #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wayner0628 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6043 +/- ##
==========================================
- Coverage 37.06% 37.04% -0.03%
==========================================
Files 1316 1316
Lines 132191 132262 +71
==========================================
- Hits 49002 48998 -4
- Misses 78926 79002 +76
+ Partials 4263 4262 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
eapolinario
reviewed
Nov 22, 2024
Signed-off-by: wayner0628 <[email protected]>
|
@eapolinario test added, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#5995
Why are the changes needed?
The current naming of the upload container in Copilot as
sidecarcan be confusing, especially since we also have a dedicateddownloadercontainer. Given that this container primarily handles upload tasks, renaming it to something more descriptive would improve readability and understanding of its role.What changes were proposed in this pull request?
Replace all occurences ofsidecarwithuploader.Simply change the string value here, suggested by @eapolinario (thank you), because replacing all occurences will introduce too many changes across the codebase.
Also, for flyte users, they will only see the name of container.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link