Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream: Add labels to published execution events #6104

Merged

Conversation

katrogan
Copy link
Contributor

Why are the changes needed?

Allows consumers to filter on arbitrary labels for execution events

What changes were proposed in this pull request?

Current state of t he world.

How was this patch tested?

Deployed to an internal setup and verified labels came through with cloud events.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Katrina Rogan <[email protected]>
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 2.32558% with 42 lines in your changes missing coverage. Please review.

Project coverage is 36.98%. Comparing base (d770918) to head (6a3ff58).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...cloudevent/implementations/cloudevent_publisher.go 0.00% 26 Missing ⚠️
...lyteidl/gen/pb-go/flyteidl/event/cloudevents.pb.go 6.25% 15 Missing ⚠️
flyteadmin/pkg/async/cloudevent/factory.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6104      +/-   ##
==========================================
- Coverage   36.99%   36.98%   -0.01%     
==========================================
  Files        1318     1318              
  Lines      132406   132439      +33     
==========================================
  Hits        48979    48979              
- Misses      79174    79207      +33     
  Partials     4253     4253              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.06% <0.00%> (-0.05%) ⬇️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <6.25%> (-0.01%) ⬇️
unittests-flyteplugins 53.82% <ø> (ø)
unittests-flytepropeller 42.60% <ø> (ø)
unittests-flytestdlib 55.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrogan katrogan merged commit 4063ab8 into master Dec 12, 2024
50 of 52 checks passed
@katrogan katrogan deleted the union/upstream-b15052d9955e29c5c6b18312ddfdc73dfdc43b6e branch December 12, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants