Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default labels and annotations to Ray worker pods too. #6107

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Dec 13, 2024

Why are the changes needed?

We already do this for the head node and submitter pod

What changes were proposed in this pull request?

See PR title

How was this patch tested?

Tested on an internal deployment, verified labels got added.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.98%. Comparing base (bd12812) to head (f239f2a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6107   +/-   ##
=======================================
  Coverage   36.98%   36.98%           
=======================================
  Files        1318     1318           
  Lines      132448   132449    +1     
=======================================
+ Hits        48982    48984    +2     
+ Misses      79213    79212    -1     
  Partials     4253     4253           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.03% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.85% <100.00%> (+<0.01%) ⬆️
unittests-flytepropeller 42.60% <ø> (ø)
unittests-flytestdlib 55.18% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) December 13, 2024 17:09
@eapolinario eapolinario merged commit e72f102 into master Dec 13, 2024
51 of 52 checks passed
@eapolinario eapolinario deleted the ray-worker-labels branch December 13, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants