Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport to release-v1.14 - Upstream ArrayNode DataMode + BindingData LiteralOffloadedMetadata idl changes (#6074) #6121

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

eapolinario
Copy link
Contributor

As title says. We'll get a flyteidl release (1.14.1) after this is merged, which will unblock flyteorg/flytekit#2940.

…l changes (#6074)

* upstream DataMode

Signed-off-by: Paul Dittamo <[email protected]>

* update descriptions

Signed-off-by: Paul Dittamo <[email protected]>

* upstream binding data idl update

Signed-off-by: Paul Dittamo <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Project coverage is 36.98%. Comparing base (8a5f54c) to head (4b1d826).
Report is 1 commits behind head on release-v1.14.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/workflow.pb.go 4.54% 21 Missing ⚠️
flyteidl/gen/pb-go/flyteidl/core/literals.pb.go 14.28% 6 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-v1.14    #6121      +/-   ##
=================================================
- Coverage          36.98%   36.98%   -0.01%     
=================================================
  Files               1318     1318              
  Lines             132449   132475      +26     
=================================================
+ Hits               48990    48991       +1     
- Misses             79206    79231      +25     
  Partials            4253     4253              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.06% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <6.89%> (-0.01%) ⬇️
unittests-flyteplugins 53.85% <ø> (ø)
unittests-flytepropeller 42.60% <ø> (ø)
unittests-flytestdlib 55.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 1895053 into release-v1.14 Dec 20, 2024
49 of 51 checks passed
@eapolinario eapolinario deleted the downstream-6074-to-release-v1.14 branch December 20, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants