Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom gpu resource name specification #6129

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Dec 29, 2024

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

Implementation of configurable GPU resource names in Kubernetes configurations, replacing hardcoded NVIDIA GPU resource names. The changes focus on resource conversion utilities in the Kubernetes plugin machinery, with comprehensive test coverage added. The PR also includes Makefile improvements for development workflow enhancement.

Unit tests added: True

Estimated effort to review (1-5, lower is better): 1

@jeevb jeevb marked this pull request as draft December 29, 2024 21:04
@flyte-bot
Copy link
Collaborator

flyte-bot commented Dec 29, 2024

Code Review Agent Run #d4de8b

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: cb764ad..cb764ad
    • Makefile
    • flyteplugins/go/tasks/pluginmachinery/flytek8s/utils.go
    • flyteplugins/go/tasks/pluginmachinery/flytek8s/utils_test.go
  • Files skipped - 0
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • GOVULNCHECK (Security Vulnerability) - ✖︎ Failed
    • SNYK (Security Vulnerability) - ✔︎ Successful
    • OWASP (Security Vulnerability) - ✔︎ Successful

AI Code Review powered by Bito Logo

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.01%. Comparing base (61838b4) to head (cb764ad).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6129   +/-   ##
=======================================
  Coverage   37.01%   37.01%           
=======================================
  Files        1318     1318           
  Lines      132525   132526    +1     
=======================================
+ Hits        49052    49055    +3     
+ Misses      79228    79226    -2     
  Partials     4245     4245           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.25% <ø> (+0.02%) ⬆️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.86% <100.00%> (+<0.01%) ⬆️
unittests-flytepropeller 42.59% <ø> (ø)
unittests-flytestdlib 55.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flyte-bot
Copy link
Collaborator

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - GPU Resource Name Configuration Enhancement

utils.go - Modified GPU resource name to be configurable instead of hardcoded

utils_test.go - Added test cases for custom GPU resource name configuration

Other Improvements - Development Workflow Enhancement

Makefile - Added run target for local development with single binary configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants