Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to Extend Flyte doc with a flowchart #763

Merged
merged 13 commits into from
Feb 22, 2021
Merged

How to Extend Flyte doc with a flowchart #763

merged 13 commits into from
Feb 22, 2021

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Feb 22, 2021

  • Update the Available Plugins section to actually have a doc on extending Flyte, the background and how to make a decision
  • Also added a new static resource

katrogan
katrogan previously approved these changes Feb 22, 2021
rsts/plugins/extend/intro.rst Outdated Show resolved Hide resolved
rsts/plugins/extend/intro.rst Outdated Show resolved Hide resolved
rsts/plugins/extend/intro.rst Outdated Show resolved Hide resolved
rsts/plugins/extend/intro.rst Outdated Show resolved Hide resolved
rsts/plugins/extend/intro.rst Outdated Show resolved Hide resolved
and you want this to be available like a template for all other users - open source or within your organization. This can be done by creating a task plugin.
A Task-plugin makes it possible for you or other users to use your idea natively within Flyte as it this capability was built into the flyte platform.

Thus for example, if you want users to write code simply using the ``@task`` decorator, but you want to provide a capability of running the function as a spark job or a sagemaker training job - then you can extend Flyte's task system - we will refer to this as the plugin and it could be possible to do the following
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one point of feedback we've received is that task_config is confusing as a name. Can we call out explicitly that task plugins are implemented with custom task configs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katrogan I dont know if the ship has sailed, but what would you call it rather. this is configuration right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, i guess configuration just has multiple interpretations and perhaps this doesn't really belong in how to create plugins anyways. i can add a PR for going over that after this one

rsts/plugins/extend/intro.rst Outdated Show resolved Hide resolved
rsts/plugins/extend/intro.rst Outdated Show resolved Hide resolved
rsts/plugins/extend/intro.rst Outdated Show resolved Hide resolved
@kumare3 kumare3 merged commit d969650 into master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants