Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_node_execution_event was missing in Flyteadmin stats #795

Merged
merged 1 commit into from
Mar 9, 2021
Merged

create_node_execution_event was missing in Flyteadmin stats #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions deployment/stats/prometheus/flyteadmin-dashboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,7 +1619,7 @@
"targets": [
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_node_execution:codes:OK[5m]))",
"expr": "sum(irate(flyte:admin:create_node_execution_event:codes:OK[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -1633,7 +1633,7 @@
},
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_node_execution:codes:InvalidArgument[5m]))",
"expr": "sum(irate(flyte:admin:create_node_execution_event:codes:InvalidArgument[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -1647,7 +1647,7 @@
},
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_node_execution:codes:AlreadyExists[5m]))",
"expr": "sum(irate(flyte:admin:create_node_execution_event:codes:AlreadyExists[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -1661,7 +1661,7 @@
},
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_node_execution:codes:FailedPrecondition[5m]))",
"expr": "sum(irate(flyte:admin:create_node_execution_event:codes:FailedPrecondition[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -1676,7 +1676,7 @@
],
"timeFrom": null,
"timeShift": null,
"title": "create_node_execution return codes",
"title": "create_node_execution_event return codes",
"tooltip": {
"msResolution": true,
"shared": true,
Expand Down Expand Up @@ -1767,7 +1767,7 @@
"targets": [
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_node_execution:errors[5m]))",
"expr": "sum(irate(flyte:admin:create_node_execution_event:errors[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -1781,7 +1781,7 @@
},
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_node_execution:success[5m]))",
"expr": "sum(irate(flyte:admin:create_node_execution_event:success[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -1796,7 +1796,7 @@
],
"timeFrom": null,
"timeShift": null,
"title": "create_node_execution success vs errors",
"title": "create_node_execution_event success vs errors",
"tooltip": {
"msResolution": true,
"shared": true,
Expand Down Expand Up @@ -1887,7 +1887,7 @@
"targets": [
{
"datasource": "",
"expr": "sum(rate(flyte:admin:create_node_execution:duration_ms[5m])) by (quantile)",
"expr": "sum(rate(flyte:admin:create_node_execution_event:duration_ms[5m])) by (quantile)",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -1902,7 +1902,7 @@
],
"timeFrom": null,
"timeShift": null,
"title": "create_node_execution Latency",
"title": "create_node_execution_event Latency",
"tooltip": {
"msResolution": true,
"shared": true,
Expand Down Expand Up @@ -1938,7 +1938,7 @@
],
"repeat": null,
"showTitle": true,
"title": "create_node_execution stats"
"title": "create_node_execution_event stats"
},
{
"collapse": true,
Expand Down Expand Up @@ -2003,7 +2003,7 @@
"targets": [
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_task_execution:codes:OK[5m]))",
"expr": "sum(irate(flyte:admin:create_task_execution_event:codes:OK[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -2017,7 +2017,7 @@
},
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_task_execution:codes:InvalidArgument[5m]))",
"expr": "sum(irate(flyte:admin:create_task_execution_event:codes:InvalidArgument[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -2031,7 +2031,7 @@
},
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_task_execution:codes:AlreadyExists[5m]))",
"expr": "sum(irate(flyte:admin:create_task_execution_event:codes:AlreadyExists[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -2045,7 +2045,7 @@
},
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_task_execution:codes:FailedPrecondition[5m]))",
"expr": "sum(irate(flyte:admin:create_task_execution_event:codes:FailedPrecondition[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -2060,7 +2060,7 @@
],
"timeFrom": null,
"timeShift": null,
"title": "create_task_execution return codes",
"title": "create_task_execution_event return codes",
"tooltip": {
"msResolution": true,
"shared": true,
Expand Down Expand Up @@ -2151,7 +2151,7 @@
"targets": [
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_task_execution:errors[5m]))",
"expr": "sum(irate(flyte:admin:create_task_execution_event:errors[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -2165,7 +2165,7 @@
},
{
"datasource": "",
"expr": "sum(irate(flyte:admin:create_task_execution:success[5m]))",
"expr": "sum(irate(flyte:admin:create_task_execution_event:success[5m]))",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -2180,7 +2180,7 @@
],
"timeFrom": null,
"timeShift": null,
"title": "create_task_execution success vs errors",
"title": "create_task_execution_event success vs errors",
"tooltip": {
"msResolution": true,
"shared": true,
Expand Down Expand Up @@ -2271,7 +2271,7 @@
"targets": [
{
"datasource": "",
"expr": "sum(rate(flyte:admin:create_task_execution:duration_ms[5m])) by (quantile)",
"expr": "sum(rate(flyte:admin:create_task_execution_event:duration_ms[5m])) by (quantile)",
"format": "time_series",
"hide": false,
"instant": false,
Expand All @@ -2286,7 +2286,7 @@
],
"timeFrom": null,
"timeShift": null,
"title": "create_task_execution Latency",
"title": "create_task_execution_event Latency",
"tooltip": {
"msResolution": true,
"shared": true,
Expand Down Expand Up @@ -2322,7 +2322,7 @@
],
"repeat": null,
"showTitle": true,
"title": "create_task_execution stats"
"title": "create_task_execution_event stats"
},
{
"collapse": true,
Expand Down
4 changes: 2 additions & 2 deletions stats/flyteadmin_dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ class FlyteAdmin(object):
"create_launch_plan",
"create_task",
"create_workflow",
"create_node_execution",
"create_task_execution",
"create_node_execution_event",
"create_task_execution_event",
"get_execution",
"get_launch_plan",
"get_task",
Expand Down