Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
EngHabu committed Mar 1, 2021
1 parent bb04640 commit 0674001
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,8 @@ linters:
- unparam
- unused
- varcheck

issues:
exclude:
# staticcheck
- "SA1019: request.GetSpec().GetInputs is deprecated: Do not use."
4 changes: 2 additions & 2 deletions pkg/config/third_party_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ type ThirdPartyConfigOptions struct {
}

type FlyteClientConfig struct {
ClientID string `json:"clientId" pflag:",public identifier for the app which handles authorization for a Flyte deployment"`
RedirectURI string `json:"redirectUri" pflag:",This is the callback uri registered with the app which handles authorization for a Flyte deployment"`
ClientID string `json:"clientId" pflag:",public identifier for the app which handles authorization for a Flyte deployment"`
RedirectURI string `json:"redirectUri" pflag:",This is the callback uri registered with the app which handles authorization for a Flyte deployment"`
}
1 change: 1 addition & 0 deletions pkg/manager/impl/execution_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,7 @@ func (m *ExecutionManager) CreateExecution(
*admin.ExecutionCreateResponse, error) {
// Prior to flyteidl v0.15.0, Inputs was held in ExecutionSpec. Ensure older clients continue to work.
if request.Inputs == nil || len(request.Inputs.Literals) == 0 {
//lint:ignore SA1019
request.Inputs = request.GetSpec().GetInputs()
}
var executionModel *models.Execution
Expand Down

0 comments on commit 0674001

Please sign in to comment.