This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
requested review from
anandswaminathan,
EngHabu,
matthewphsmith and
wild-endeavor
as code owners
January 22, 2021 22:42
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 61.79% 61.75% -0.05%
==========================================
Files 105 105
Lines 7534 7541 +7
==========================================
+ Hits 4656 4657 +1
- Misses 2286 2292 +6
Partials 592 592
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
wild-endeavor
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will just work? nothing else needs to happen?
@wild-endeavor yep, the user just has to specify the filters |
13 tasks
EngHabu
pushed a commit
that referenced
this pull request
Feb 27, 2021
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
added a commit
that referenced
this pull request
Mar 2, 2021
* Move scopes to config Signed-off-by: Haytham Abuelfutuh <[email protected]> * missed Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update handlers.go Signed-off-by: Haytham Abuelfutuh <[email protected]> * go get propeller at v0.5.12 (#146) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to using latest flytepropeller v0.5.13 (#148) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update propeller to 0.5.14 (#149) * Update propeller * cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * Filter executions by user (#150) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update CI post migration Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update codecov link Signed-off-by: Haytham Abuelfutuh <[email protected]> * Publish raw events (#151) Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix test Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix token retrieval from cookies Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix unit tests and lint Signed-off-by: Haytham Abuelfutuh <[email protected]> * Move to const Signed-off-by: Haytham Abuelfutuh <[email protected]> * Revert Auth config Signed-off-by: Haytham Abuelfutuh <[email protected]> * Revert kube config path Signed-off-by: Haytham Abuelfutuh <[email protected]> * Use access token when posting to IdP Signed-off-by: Haytham Abuelfutuh <[email protected]> * Ignore refresh token error Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Expose openId metadata endpoint and expose scopes in /config endpoint Signed-off-by: Haytham Abuelfutuh <[email protected]> * mod tidy Signed-off-by: Haytham Abuelfutuh <[email protected]> * rename Signed-off-by: Haytham Abuelfutuh <[email protected]> * lint Signed-off-by: Haytham Abuelfutuh <[email protected]> * unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Co-authored-by: Katrina Rogan <[email protected]> Co-authored-by: tnsetting <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Move scopes to config Signed-off-by: Haytham Abuelfutuh <[email protected]> * missed Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update handlers.go Signed-off-by: Haytham Abuelfutuh <[email protected]> * go get propeller at v0.5.12 (#146) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to using latest flytepropeller v0.5.13 (#148) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update propeller to 0.5.14 (#149) * Update propeller * cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * Filter executions by user (#150) Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update CI post migration Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update codecov link Signed-off-by: Haytham Abuelfutuh <[email protected]> * Publish raw events (#151) Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix test Signed-off-by: Haytham Abuelfutuh <[email protected]> * wip Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix token retrieval from cookies Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix unit tests and lint Signed-off-by: Haytham Abuelfutuh <[email protected]> * Move to const Signed-off-by: Haytham Abuelfutuh <[email protected]> * Revert Auth config Signed-off-by: Haytham Abuelfutuh <[email protected]> * Revert kube config path Signed-off-by: Haytham Abuelfutuh <[email protected]> * Use access token when posting to IdP Signed-off-by: Haytham Abuelfutuh <[email protected]> * Ignore refresh token error Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Expose openId metadata endpoint and expose scopes in /config endpoint Signed-off-by: Haytham Abuelfutuh <[email protected]> * mod tidy Signed-off-by: Haytham Abuelfutuh <[email protected]> * rename Signed-off-by: Haytham Abuelfutuh <[email protected]> * lint Signed-off-by: Haytham Abuelfutuh <[email protected]> * unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Co-authored-by: Katrina Rogan <[email protected]> Co-authored-by: tnsetting <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Promote user as a filterable column for execution models
Type
Are all requirements met?
Complete description
Tracking Issue
flyteorg/flyte#671
Follow-up issue
NA