This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Refactors Flyteadmin to make every command, externally invokable #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
kumare3
requested review from
katrogan,
wild-endeavor,
anandswaminathan and
EngHabu
as code owners
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 60.32% 60.47% +0.15%
==========================================
Files 150 150
Lines 10683 10686 +3
==========================================
+ Hits 6444 6462 +18
+ Misses 3544 3526 -18
- Partials 695 698 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
katrogan
approved these changes
Mar 24, 2022
kumare3
changed the title
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
#370) * SQLite support Signed-off-by: Ketan Umare <[email protected]> * Move migrate commands Signed-off-by: Ketan Umare <[email protected]> * Clusterresource controller refactor Signed-off-by: Ketan Umare <[email protected]> * lint fix Signed-off-by: Ketan Umare <[email protected]> * test fix Signed-off-by: Ketan Umare <[email protected]> * updated Signed-off-by: Ketan Umare <[email protected]> * Updated to handle additional servers Signed-off-by: Ketan Umare <[email protected]> * lint fix Signed-off-by: Ketan Umare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As we make Flyteadmin ready to be converted to Flyte single binary mode, this refactor make it trivial to encapsulate it in the single binary
Type
Are all requirements met?
Issue
flyteorg/flyte#2266
Follow-up issue
NA