This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add interruptible override to workflow execution config #minor #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 13, 2022 13:43
Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
…ptible Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
requested review from
katrogan,
wild-endeavor,
anandswaminathan,
EngHabu and
kumare3
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
added 2 commits
April 26, 2022 11:08
Allows for distinguishment between no value being provided and an override to false Signed-off-by: Nick Müller <[email protected]>
…ptible Signed-off-by: Nick Müller <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 61.15% 61.20% +0.04%
==========================================
Files 154 154
Lines 11093 11101 +8
==========================================
+ Hits 6784 6794 +10
- Misses 3602 3604 +2
+ Partials 707 703 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 2 commits
April 27, 2022 11:52
Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
|
@pmahindrakar-oss dependencies been cleaned up with newly released versions of flyteidl/flyteadmin + |
pmahindrakar-oss
approved these changes
May 3, 2022
|
@katrogan can you review it aswell |
katrogan
approved these changes
May 3, 2022
|
Congrats on merging your first pull request! 🎉 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Fixed minor log message formatting Signed-off-by: Nick Müller <[email protected]> * Added override for interruptible flag to execution config Signed-off-by: Nick Müller <[email protected]> * Interruptible override now uses BoolValue wrapper Allows for distinguishment between no value being provided and an override to false Signed-off-by: Nick Müller <[email protected]> * Test comments cleanup Signed-off-by: Nick Müller <[email protected]> * Use released flyteidl/flytepropeller versions Signed-off-by: Nick Müller <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Applies new
interruptibleflag from updatedExecutionSpecto workflow execution config, allowing for workflows to be flagged as interruptible for a single execution.Type
Are all requirements met?
Complete description
The newly introduced
interruptibleflag of anExecutionSpecis merged into a workflow's execution config using the existingmergeIntoExecConfighelper for both launch plan and single task executions. Propeller will use the flag to override theinterruptiblesetting for a single execution while still following the existing override rules.Due to the shared
WorkflowExecutionConfigInterfaceused bymergeIntoExecConfig, it's now also possible to specify a "global default" via theApplicationConfig(defaults tofalseto ensure backward compatibility), however it seems likemergeIntoExecConfignever actually reaches this part since there's always something being overridden (k8s security contexst by default)...Tests have been added covering the flyteadmin part of the interruptible override, manual smoke testing seems to behave correctly (workflow/single task executions + relaunches have been checked using the flytesnacks repo).
Additionally, some minor log cleanup was included (incorrect formatting).
Tracking Issue
flyteorg/flyte#2284
Follow-up issue
NA