Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update github tag action #414

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Update github tag action #414

merged 1 commit into from
Apr 25, 2022

Conversation

katrogan
Copy link
Contributor

Signed-off-by: Katrina Rogan [email protected]

TL;DR

Signed-off-by: Katrina Rogan [email protected]

matches flyteorg/flytetools#62

see https://github.com/anothrNick/github-tag-action/issues/147

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan merged commit aa53a53 into master Apr 25, 2022
@katrogan katrogan deleted the anothrNick branch April 25, 2022 20:35
@ckiosidis
Copy link
Contributor

Did something change in this PR with the logging?
We see a lot of unstructured gorm logs in flyteadmin.

example


{"data":{"src":"handlers.go:237"},"message":"Running authentication gRPC interceptor","severity":"DEBUG","timestamp":"2022-05-02T07:56:12Z"}
{"data":{"src":"handlers.go:193"},"message":"gRPC server info in logging interceptor []method [/flyteidl.service.AdminService/ListExecutions]\n","severity":"DEBUG","timestamp":"2022-05-02T07:56:12Z"}
...
2022/05/02 07:56:12 /go/src/github.com/flyteorg/flyteadmin/pkg/repositories/gormimpl/execution_repo.go:103
[18.420ms] [rows:0] SELECT * FROM "executions" WHERE executions.execution_project = 'some-project' AND executions.execution_domain = 'staging' AND executions.phase in ('RUNNING') AND executions.started_at >= '2022-04-08T07:56:12' AND executions.started_at <= '2022-05-02T07:46:12' AND executions.state = 'EXECUTION_ACTIVE' LIMIT 100

@katrogan
Copy link
Contributor Author

katrogan commented May 3, 2022

resolving in slack.

eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Katrina Rogan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants