Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Reverting the default values for service account to empty #450

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

pmahindrakar-oss
Copy link
Contributor

Signed-off-by: Prafulla Mahindrakar [email protected]

TL;DR

This could be a temporary fix to unblock spark plugin issue.
But long term we want flyteadmin to be in control of all settings and not have logic in other components overriding it.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes flyteorg/flyte#2595

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #450 (6cc3074) into master (ccf8286) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 6cc3074 differs from pull request most recent head 0471ff9. Consider uploading reports for the commit 0471ff9 to get more accurate results

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   61.48%   61.49%   +0.01%     
==========================================
  Files         157      157              
  Lines       11223    11226       +3     
==========================================
+ Hits         6900     6903       +3     
  Misses       3609     3609              
  Partials      714      714              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtime/application_config_provider.go 33.33% <ø> (ø)
pkg/manager/impl/execution_manager.go 74.75% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf8286...0471ff9. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Flyte spark tasks are not being executed with spark service account
2 participants