This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add count to execution repo interfaces #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Dye <[email protected]>
Signed-off-by: Andrew Dye <[email protected]>
andrewwdye
requested review from
katrogan,
wild-endeavor,
anandswaminathan,
EngHabu,
kumare3 and
pmahindrakar-oss
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 61.51% 61.59% +0.07%
==========================================
Files 157 157
Lines 11248 11305 +57
==========================================
+ Hits 6919 6963 +44
- Misses 3612 3619 +7
- Partials 717 723 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Andrew Dye <[email protected]>
andrewwdye
force-pushed
the
execution-repo-count
branch
from
f2b0ec8 to
bb956c9
Compare
katrogan
reviewed
Aug 25, 2022
…erface Signed-off-by: Andrew Dye <[email protected]>
Signed-off-by: Andrew Dye <[email protected]>
|
Fyi, created flyteorg/flyte#2814 for previously failing Check Go Generate. Looks like an inconsistency between go 1.18 and 1.19. |
katrogan
approved these changes
Aug 26, 2022
|
Congrats on merging your first pull request! 🎉 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add a
Countinterface and implementation toExecutionRepo,NodeExecutionRepo, andTaskExecutionRepo. This allows counting executions matching a filter set without needing to materialize the list.Type
Are all requirements met?
Complete description
Workflow, node, and task execution states are stored in a GORM DB. This change adds a
Countinterface toExecutionRepo,NodeExecutionRepo, andTaskExecutionRepoto query the count of executions efficiently (instead of materializing the list and summing). The interface acceptsInlineFiltersandMapFilters, similar to theListinterfaces and theListResourceInputparam.Relevant unit tests added.
This change also
make goimports, which led to updates in a number of unrelated filesTracking Issue
NA
Follow-up issue
NA