This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Increase allowedExecutionNameLength to 63
#466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Mehta <[email protected]>
rahul-theorem
requested review from
katrogan,
wild-endeavor,
anandswaminathan,
EngHabu,
kumare3 and
pmahindrakar-oss
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
katrogan
reviewed
Aug 30, 2022
Signed-off-by: Rahul Mehta <[email protected]>
|
Just fixed the failing test, @katrogan would it be possible to re-run the CI checks (looks like it's required since this is my first PR to flyteadmin)? |
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 61.64% 61.64%
=======================================
Files 157 157
Lines 11305 11305
=======================================
Hits 6969 6969
Misses 3613 3613
Partials 723 723
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
katrogan
approved these changes
Aug 31, 2022
|
Congrats on merging your first pull request! 🎉 |
9 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Increase `allowedExecutionNameLength` to 63 Signed-off-by: Rahul Mehta <[email protected]> * Update TestValidExecutionIdInvalidLength Signed-off-by: Rahul Mehta <[email protected]> Signed-off-by: Rahul Mehta <[email protected]> Signed-off-by: Rahul Mehta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rahul Mehta [email protected]
TL;DR
Increase
allowedExecutionNameLengthfrom 20 to 63 to allow more legible human-readable execution IDsType
Are all requirements met?
Complete description
See title/summary
Tracking Issue
Closes flyteorg/flyte#2824
Follow-up issue
NA