This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Propagate request id on incoming and outgoing requests #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 58.70% 60.19% +1.49%
==========================================
Files 168 168
Lines 16307 13326 -2981
==========================================
- Hits 9573 8022 -1551
+ Misses 5884 4454 -1430
Partials 850 850
Flags with carried forward coverage won't be shown. Click here to find out more. |
katrogan
previously approved these changes
Jul 13, 2023
EngHabu
requested review from
wild-endeavor,
kumare3,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
katrogan
previously approved these changes
Jul 13, 2023
Signed-off-by: Haytham Abuelfutuh <[email protected]>
katrogan
approved these changes
Jul 13, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Parses out incoming request id if set on grpc or http headers and set it on the context as well as on outgoing metadata for all grpc calls that happen within the same context.
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#3577