This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
OAuth2 #8
Merged
OAuth2 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd cookies into a cookie manager from other files
…ning up token validation logic
…l, add a new redirect url, move config to a separate object inside the auth package
* switched out the jwt-go library for the go-oidc library, which is also capable of handling jwt verification, and is even better because it caches jwks key sets. * delete old tests and comment
…an just the RFC specified ones like 'authorization' because Envoy.
…t, add a new grpc interceptor that renames the authorization header from a custom one to the official one
…o the auth context setup part
…cope to authorization request
CORS support for gwmux
katrogan
previously approved these changes
Oct 31, 2019
added 19 commits
October 31, 2019 16:59
katrogan
approved these changes
Nov 11, 2019
schottra
added a commit
that referenced
this pull request
Nov 14, 2019
* origin/master: Metadata url and base url as items in the auth context (#33) OAuth2 (#8) Log links merging logic should take log link names into account (#32) Generic type support in workflow compiler (#31) Fix invalid filter function error message (#30) Support postgres extra options [gcp] (#27) Fix no auth provider [gcp] (#28)
|
As a reminder, https://github.com/lyft/flyteadmin/pull/8/files#diff-10cb7b7d10da61a9793a32f86a893485L5 makes sandbox deployment in |
|
@honnix thank you... I'll fix soon. forgot to do that. |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
This adds OAuth2 support for Flyte Admin. * Most of the logic has been implemented in the auth package. Care was taken, at least attepted, to separate logic that exclusively dealt with oauth into this package. * The code implements the authorization code flow, which means you'll need a client secret, and there is no implicit flow. * Most of the core logic is in the `handlers.go` file, which has functions that create handlers (both HTTP and gRPC) that can be attached to existing servers. See the `serve.go` file to see usage. * Encrypted cookies are used to store the user's access (oidc) and refresh tokens. Two other cookies (the CSRF token and the final redirect page) are stored unencypted. * Reworked some of the options handling around the base server logic in `serve.go`, specifically around SSL handling. Docs forthcoming in the main flyte repo. Also more unit tests and metrics here in another PR after the remaining auth work is done.
wild-endeavor
added a commit
that referenced
this pull request
Sep 26, 2023
Also clean up the logic around resolving parameter and literal map a bit more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds OAuth2 support for Flyte Admin.
handlers.gofile, which has functions that create handlers (both HTTP and gRPC) that can be attached to existing servers. See theserve.gofile to see usage.serve.go, specifically around SSL handling.Docs forthcoming in the main flyte repo. Also more unit tests and metrics here in another PR after the remaining auth work is done.