This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Implement UpdateWorkflow #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
requested review from
anandswaminathan,
EngHabu,
kumare3,
matthewphsmith and
wild-endeavor
as code owners
katrogan
requested review from
schottra
and removed request for
matthewphsmith and
kumare3
EngHabu
previously approved these changes
Apr 2, 2020
schottra
approved these changes
Apr 2, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR implements the UpdateWorkflow endpoint for setting workflow state.
Type
Are all requirements met?
Complete description
This PR allows users to toggle workflow visibility by setting workflow state. Now that we have authentication combined with an audit trail, this allows us to track who updates workflows should users request it. This change also adds a migration to add the state column to the workflows table and a separate migration to backfill it.
This should seamlessly allow filtering on workflow state from the UI now.
Tracking Issue
flyteorg/flyte#235
Follow-up issue
NA