This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Downgrade info logs in clusterresource controller #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
requested review from
anandswaminathan,
EngHabu,
kumare3,
matthewphsmith and
wild-endeavor
as code owners
katrogan
requested review from
jonathanburns
and removed request for
EngHabu and
anandswaminathan
kumare3
reviewed
Apr 13, 2020
| @@ -239,14 +239,14 @@ func (c *controller) syncNamespace(ctx context.Context, namespace NamespaceName, | |||
| templateFileName := templateFile.Name() | |||
| if filepath.Ext(templateFileName) != ".yaml" { | |||
| // nothing to do. | |||
| logger.Infof(ctx, "syncing namespace [%s]: ignoring unrecognized filetype [%s]", | |||
| logger.Debugf(ctx, "syncing namespace [%s]: ignoring unrecognized filetype [%s]", | |||
There was a problem hiding this comment.
is this not a warning? We are ignoring something?
There was a problem hiding this comment.
not necessarily, we only look at yaml files (because of how kubernetes mounts configmaps with symlinks this was causing problems in the sandbox mode)
kumare3
reviewed
Apr 13, 2020
| @@ -315,7 +315,7 @@ func (c *controller) syncNamespace(ctx context.Context, namespace NamespaceName, | |||
|
|
|||
| if err != nil { | |||
| c.metrics.TemplateUpdateErrors.Inc() | |||
| logger.Infof(ctx, "Failed to update resource [%+v] in namespace [%s] with err :%v", | |||
| logger.Warningf(ctx, "Failed to update resource [%+v] in namespace [%s] with err :%v", | |||
There was a problem hiding this comment.
%+v, maybe that is a problem?
There was a problem hiding this comment.
we are dumping out the entire object, is that want you intend to do?
There was a problem hiding this comment.
we're only dumping out the Kind
|
@katrogan if you think the intention matches the code, I am good to go with this. Ping me and we can approve it |
wild-endeavor
approved these changes
Apr 30, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This change downgrades info logs in clusterresource controller to debug level to reduce its overall spamminess and address disk space pressure for docker-for-mac deployments.
Type
Are all requirements met?
Complete description
Tracking Issue
flyteorg/flyte#250
Follow-up issue
NA