chore: fix

Signed-off-by: Carina Ursu <[email protected]>
flyteorg · May 5, 2022 · 14bb53b · 14bb53b
1 parent 4099b52
commit 14bb53b
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 16 deletions.
diff --git a/packages/zapp/console/src/components/Literals/DeprecatedLiteralMapViewer.tsx b/packages/zapp/console/src/components/Literals/DeprecatedLiteralMapViewer.tsx
@@ -16,7 +16,7 @@ export const NoDataIsAvailable = () => {
 };
 
 /** Renders a LiteralMap as a formatted object */
-export const LiteralMapViewer: React.FC<{
+export const DeprecatedLiteralMapViewer: React.FC<{
   className?: string;
   map: LiteralMap | null;
   showBrackets?: boolean;

diff --git a/packages/zapp/console/src/components/Literals/__stories__/Collection.stories.tsx b/packages/zapp/console/src/components/Literals/__stories__/Collection.stories.tsx
@@ -4,7 +4,6 @@ import * as React from 'react';
 import { Card, CardContent } from '@material-ui/core';
 import { LiteralMapViewer } from '../LiteralMapViewer';
 import { DeprecatedLiteralMapViewer } from '../DeprecatedLiteralMapViewer';
-import { CardDecorator } from './CardDecorator';
 import {
   binaryLiterals,
   blobLiterals,
@@ -15,7 +14,6 @@ import {
 } from './literalValues';
 
 const stories = storiesOf('Literals/Collection', module);
-stories.addDecorator(CardDecorator);
 
 function renderCollection(label: string, collection: LiteralCollection) {
   const map = { literals: { [label]: { collection, value: 'collection' } } };

diff --git a/packages/zapp/console/src/components/Literals/__stories__/Map.stories.tsx b/packages/zapp/console/src/components/Literals/__stories__/Map.stories.tsx
@@ -2,7 +2,6 @@ import { storiesOf } from '@storybook/react';
 import { LiteralMap } from 'models/Common/types';
 import * as React from 'react';
 import { Card, CardContent } from '@material-ui/core';
-import { CardDecorator } from './CardDecorator';
 import {
   binaryLiterals,
   blobLiterals,
@@ -15,7 +14,6 @@ import { LiteralMapViewer } from '../LiteralMapViewer';
 import { DeprecatedLiteralMapViewer } from '../DeprecatedLiteralMapViewer';
 
 const stories = storiesOf('Literals/Map', module);
-stories.addDecorator(CardDecorator);
 
 function renderMap(label: string, map: LiteralMap) {
   const fullMap = { literals: { [label]: { map, value: 'map' } } };

diff --git a/packages/zapp/console/src/components/Literals/__stories__/ProtobufStruct.stories.tsx b/packages/zapp/console/src/components/Literals/__stories__/ProtobufStruct.stories.tsx
@@ -2,14 +2,12 @@ import { storiesOf } from '@storybook/react';
 import { ProtobufListValue, ProtobufStruct } from 'models/Common/types';
 import * as React from 'react';
 import { Card, CardContent } from '@material-ui/core';
-import { CardDecorator } from './CardDecorator';
 import { protobufValues } from './protobufValues';
 import { LiteralMapViewer } from '../LiteralMapViewer';
 
 import { DeprecatedLiteralMapViewer } from '../DeprecatedLiteralMapViewer';
 
 const stories = storiesOf('Literals/ProtobufStruct', module);
-stories.addDecorator(CardDecorator);
 
 function renderStruct(label: string, struct: ProtobufStruct) {
   const map = {

diff --git a/packages/zapp/console/src/components/Literals/__stories__/Scalar.stories.tsx b/packages/zapp/console/src/components/Literals/__stories__/Scalar.stories.tsx
@@ -2,9 +2,7 @@ import { storiesOf } from '@storybook/react';
 import { Scalar } from 'models/Common/types';
 import * as React from 'react';
 import { Card, CardContent } from '@material-ui/core';
-import { ScalarValue } from '../Scalar/ScalarValue';
 import { LiteralMapViewer } from '../LiteralMapViewer';
-import { CardDecorator } from './CardDecorator';
 import {
   binaryScalars,
   blobScalars,
@@ -16,7 +14,6 @@ import {
 import { DeprecatedLiteralMapViewer } from '../DeprecatedLiteralMapViewer';
 
 const stories = storiesOf('Literals/Scalar', module);
-stories.addDecorator(CardDecorator);
 
 var renderScalars = (scalars: Dictionary<Scalar>) => {
   const literals = {};

diff --git a/packages/zapp/console/src/components/Literals/__stories__/StructuredDataSet.stories.tsx b/packages/zapp/console/src/components/Literals/__stories__/StructuredDataSet.stories.tsx
@@ -1,14 +1,13 @@
 import { storiesOf } from '@storybook/react';
 import { Scalar } from 'models/Common/types';
+import { Card, CardContent } from '@material-ui/core';
 import * as React from 'react';
 import { Core } from 'flyteidl';
 import { LiteralMapViewer } from '../LiteralMapViewer';
-import { CardDecorator } from './CardDecorator';
 import { blobScalars } from './scalarValues';
 import { extractSimpleTypes, extractSchemaTypes, extractBlobTypes } from './helpers/typeGenerators';
 
 const stories = storiesOf('Literals/StructuredDataSet', module);
-stories.addDecorator(CardDecorator);
 
 function generateStructuredDataset(label: string, literalType: Core.ILiteralType) {
   return {
@@ -156,13 +155,17 @@ function generateEnumTypes() {
 }
 
 const renderScalars = (scalars: Dictionary<Scalar>) => {
-  return Object.entries(scalars).map(([label, value]) => {
+  const items = Object.entries(scalars).map(([_label, value]) => {
     return (
-      <>
-        <LiteralMapViewer map={value} />
-      </>
+      <Card style={{ margin: '16px 0', width: '430px' }}>
+        <CardContent>
+          <LiteralMapViewer map={value} />
+        </CardContent>
+      </Card>
     );
   });
+
+  return <div style={{ display: 'flex', flexDirection: 'column' }}>{items}</div>;
 };
 
 stories.add('Simple types', () => <>{renderScalars(generateSimpleTypes())}</>);