chore: more tests

Signed-off-by: Carina Ursu <[email protected]>
flyteorg · Apr 14, 2023 · 1d37237 · 1d37237
1 parent 546b3b6
commit 1d37237
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/packages/console/src/components/Executions/Tables/NodeExecutionRow.tsx b/packages/console/src/components/Executions/Tables/NodeExecutionRow.tsx
@@ -114,7 +114,7 @@ export const NodeExecutionRow: React.FC<NodeExecutionRowProps> = ({
             className={classnames(
               tableStyles.rowColumn,
               tableStyles.expander,
-              node.grayedOut ? grayedClassName : '',
+              node.filteredOut ? grayedClassName : '',
             )}
           >
             <div className={styles.namesContainerExpander}>
@@ -127,7 +127,7 @@ export const NodeExecutionRow: React.FC<NodeExecutionRowProps> = ({
               className={classnames(
                 tableStyles.rowColumn,
                 className,
-                node.grayedOut ? grayedClassName : '',
+                node.filteredOut ? grayedClassName : '',
               )}
             >
               {cellRenderer({
@@ -149,7 +149,7 @@ export const NodeExecutionRow: React.FC<NodeExecutionRowProps> = ({
                   inputUri: '',
                   scopedId: node.scopedId,
                 },
-                className: node.grayedOut ? tableStyles.grayed : '',
+                className: node.filteredOut ? tableStyles.grayed : '',
               })}
             </div>
           ))}

diff --git a/packages/console/src/components/Executions/Tables/NodeExecutionsTable.tsx b/packages/console/src/components/Executions/Tables/NodeExecutionsTable.tsx
@@ -95,7 +95,7 @@ const filterNodes = (
     const result = hasFilteredChildren || shouldBeIncluded;
 
     if (hasFilteredChildren && !shouldBeIncluded) {
-      node.grayedOut = true;
+      node.filteredOut = true;
     }
 
     return result;

diff --git a/...mponents/Executions/contextProvider/NodeExecutionDetails/NodeExecutionDynamicProvider.tsx b/...mponents/Executions/contextProvider/NodeExecutionDetails/NodeExecutionDynamicProvider.tsx
@@ -46,9 +46,14 @@ export const NodeExecutionDynamicContext =
 
 const checkEnableChildQuery = (
   childExecutions: NodeExecution[],
-  nodeExecution: WorkflowNodeExecution,
+  node: dNode,
   inView: boolean,
 ) => {
+  const nodeExecution = node.execution;
+
+  if(!nodeExecution){
+    return false
+  }
   // check that we fetched all children otherwise force fetch
   const missingChildren =
     isParentNode(nodeExecution) && !childExecutions.length;
@@ -59,7 +64,7 @@ const checkEnableChildQuery = (
 
   const executionRunning = !nodeExecutionIsTerminal(nodeExecution);
 
-  const tasksFetched = nodeExecution.tasksFetched;
+  const tasksFetched = (nodeExecution as WorkflowNodeExecution).tasksFetched;
 
   const forceRefetch =
     inView &&
@@ -122,7 +127,7 @@ export const NodeExecutionDynamicProvider = ({
     () => {
       const shouldRun = checkEnableChildQuery(
         childExecutions,
-        nodeExecution!,
+        node,
         !!overloadedInView,
       );
 

diff --git a/packages/console/src/models/Graph/types.ts b/packages/console/src/models/Graph/types.ts
@@ -59,7 +59,7 @@ export interface dNode {
   nodes: Array<dNode>;
   edges: Array<dEdge>;
   expanded?: boolean;
-  grayedOut?: boolean;
+  filteredOut?: boolean;
   level?: number;
   execution?: WorkflowNodeExecution;
   isParentNode?: boolean;