Skip to content

Commit

Permalink
chore: add item when mapped task (#761)
Browse files Browse the repository at this point in the history
* feat: (wip) add item when mapped task

Signed-off-by: Jason Porter <[email protected]>

* chore: progress

Signed-off-by: Carina Ursu <[email protected]>

* chore: pass mapped item

Signed-off-by: Carina Ursu <[email protected]>

---------

Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Co-authored-by: Carina Ursu <[email protected]>
  • Loading branch information
jsonporter and ursucarina authored May 18, 2023
1 parent e316bef commit 333940f
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/console/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@flyteorg/console",
"version": "0.0.34",
"version": "0.0.35",
"description": "Flyteconsole main app module",
"main": "./dist/index.js",
"module": "./lib/index.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ export const MapTaskExecutionDetails: React.FC<
{filteredResources.map(item => {
const attempt = item.retryAttempt ?? 0;
const headerText = formatRetryAttempt(attempt);

return (
<div key={`card-${attempt}`}>
<TaskExecutionLogsCard
taskExecution={taskExecution}
headerText={headerText}
phase={item.phase ?? TaskExecutionPhase.UNDEFINED}
logs={item.logs ?? []}
mappedItem={item}
/>
</div>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ interface TaskExecutionLogsCardProps {
headerText: string;
phase: TaskExecutionPhase;
logs: Core.ITaskLog[];
mappedItem?: any;
}

export const TaskExecutionLogsCard: React.FC<
Expand Down
4 changes: 2 additions & 2 deletions packages/console/src/components/Executions/contexts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import {
Execution,
ExecutionData,
LogsByPhase,
MapTaskExecution,
NodeExecution,
TaskExecution,
} from 'models/Execution/types';
import { dNode } from 'models/Graph/types';
import { createContext } from 'react';
Expand All @@ -13,7 +13,7 @@ export interface ExecutionContextData {
execution: Execution;
}

export type WorkflowTaskExecution = TaskExecution & {
export type WorkflowTaskExecution = MapTaskExecution & {
task?: Task;
taskData?: ExecutionData;
};
Expand Down
1 change: 1 addition & 0 deletions packages/console/src/models/Task/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export * from './constants';
export * from './types';
export * from './api';
export * from './utils';
2 changes: 1 addition & 1 deletion website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"dependencies": {
"@flyteorg/common": "^0.0.4",
"@flyteorg/console": "^0.0.34",
"@flyteorg/console": "^0.0.35",
"long": "^4.0.0",
"protobufjs": "~6.11.3",
"react-ga4": "^1.4.1",
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2020,7 +2020,7 @@ __metadata:
resolution: "@flyteconsole/client-app@workspace:website"
dependencies:
"@flyteorg/common": ^0.0.4
"@flyteorg/console": ^0.0.34
"@flyteorg/console": ^0.0.35
"@types/long": ^3.0.32
long: ^4.0.0
protobufjs: ~6.11.3
Expand Down Expand Up @@ -2059,7 +2059,7 @@ __metadata:
languageName: unknown
linkType: soft

"@flyteorg/console@^0.0.34, @flyteorg/console@workspace:packages/console":
"@flyteorg/console@^0.0.35, @flyteorg/console@workspace:packages/console":
version: 0.0.0-use.local
resolution: "@flyteorg/console@workspace:packages/console"
dependencies:
Expand Down

0 comments on commit 333940f

Please sign in to comment.