fix: add default disabled state for only mine filter (#585)

* fix: add default disabled state for only mine filter Signed-off-by: Olga Nad <[email protected]> * fix: tests Signed-off-by: Olga Nad <[email protected]> * fix: use api context to default filter state Signed-off-by: Olga Nad <[email protected]> * fix: revert test updates Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>
flyteorg · Sep 14, 2022 · 6fa1cc1 · 6fa1cc1
1 parent a5cad5d
commit 6fa1cc1
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/zapp/console/src/components/Executions/filters/useOnlyMyExecutionsFilterState.ts b/packages/zapp/console/src/components/Executions/filters/useOnlyMyExecutionsFilterState.ts
@@ -4,6 +4,7 @@ import { useUserProfile } from 'components/hooks/useUserProfile';
 import { useOnlyMineSelectedValue } from 'components/hooks/useOnlyMineSelectedValue';
 import { OnlyMyFilter } from 'basics/LocalCache/onlyMineDefaultConfig';
 import { FeatureFlag, useFeatureFlag } from 'basics/FeatureFlags';
+import { useFlyteApi } from '@flyteconsole/flyte-api';
 
 interface OnlyMyExecutionsFilterState {
   onlyMyExecutionsValue: boolean;
@@ -25,12 +26,14 @@ export function useOnlyMyExecutionsFilterState({
   initialValue,
 }: OnlyMyExecutionsFilterStateProps): OnlyMyExecutionsFilterState {
   const profile = useUserProfile();
+  const apiContext = useFlyteApi();
   const userId = profile.value?.subject ?? '';
   const isFlagEnabled = useFeatureFlag(FeatureFlag.OnlyMine);
   const onlyMineExecutionsSelectedValue = useOnlyMineSelectedValue(OnlyMyFilter.OnlyMyExecutions);
   const [onlyMyExecutionsValue, setOnlyMyExecutionsValue] = useState<boolean>(
     isFlagEnabled ? onlyMineExecutionsSelectedValue : initialValue ?? false, // if flag is enable let's use the value from only mine
   );
+  const defaultIsFilterDisabled = apiContext ? false : true;
 
   const getFilter = (): FilterOperation | null => {
     if (!onlyMyExecutionsValue) {
@@ -53,7 +56,7 @@ export function useOnlyMyExecutionsFilterState({
 
   return {
     onlyMyExecutionsValue,
-    isFilterDisabled: isFilterDisabled ?? false,
+    isFilterDisabled: isFilterDisabled ?? defaultIsFilterDisabled,
     onOnlyMyExecutionsFilterChange: setOnlyMyExecutionsValue,
     getFilter,
   };