fix: backfill index on execution task logs (#725)

* chore: backfill index on execution task logs Signed-off-by: Carina Ursu <[email protected]> * chore: add comments Signed-off-by: Carina Ursu <[email protected]> * chore: bump version Signed-off-by: Carina Ursu <[email protected]> * chore: remove backfill Signed-off-by: Carina Ursu <[email protected]> * chore: lint Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]>
flyteorg · Mar 30, 2023 · d5a17a2 · d5a17a2
1 parent 45c6386
commit d5a17a2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/packages/console/package.json b/packages/console/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@flyteorg/console",
-  "version": "0.0.13",
+  "version": "0.0.14",
   "description": "Flyteconsole main app module",
   "main": "./dist/index.js",
   "module": "./lib/index.js",

diff --git a/packages/console/src/components/Executions/TaskExecutionsList/utils.ts b/packages/console/src/components/Executions/TaskExecutionsList/utils.ts
@@ -65,7 +65,9 @@ export const getGroupedLogs = (
       // if there is no log with active url, just create an item with externalId,
       // for user to understand which array items are in this state
       const newLogs =
-        item.logs.length > 0 ? item.logs : [{ name: item.externalId }];
+        item.logs.length > 0
+          ? item.logs.map(l => ({ ...l, index: item.index }))
+          : [{ name: item.externalId, index: item.index }];
       logsByPhase.set(
         phase,
         currentValue ? [...currentValue, ...newLogs] : [...newLogs],

diff --git a/packages/console/src/components/common/MapTaskExecutionsList/TaskNameList.tsx b/packages/console/src/components/common/MapTaskExecutionsList/TaskNameList.tsx
@@ -43,7 +43,7 @@ export const TaskNameList = ({
 
   return (
     <>
-      {logs.map((log, taskIndex) => {
+      {logs.map((log, _taskIndex) => {
         const taskLogName = getTaskLogName(
           taskExecution.id.taskId.name,
           log.name ?? '',
@@ -57,7 +57,11 @@ export const TaskNameList = ({
           )?.cacheStatus;
 
         const handleClick = () => {
-          onTaskSelected({ ...taskExecution, taskIndex });
+          // Use the resource's index instead of the log index
+          onTaskSelected({
+            ...taskExecution,
+            taskIndex: (log as any).index || 0,
+          });
         };
 
         return (