feat: differentiate between cache disabled and cache put failure #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James <[email protected]>
ursucarina
approved these changes
Mar 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 66.95% 66.85% -0.11%
==========================================
Files 455 455
Lines 11280 11282 +2
Branches 2077 2077
==========================================
- Hits 7553 7543 -10
- Misses 3727 3739 +12
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jsonporter
changed the title
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
4nalog
pushed a commit
that referenced
this pull request
Mar 30, 2023
fix: add icon for put failure Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]>
jsonporter
added a commit
that referenced
this pull request
Mar 30, 2023
* fix: type error on invalid nested json input Signed-off-by: 4nalog <[email protected]> * LaunchForm RJSF Form issue (#692) * fix: launchform Signed-off-by: James <[email protected]> * fix: stuck issue Signed-off-by: James <[email protected]> * fix: on form change Signed-off-by: James <[email protected]> * fix: merge master into branch Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: bump minor version Signed-off-by: 4nalog <[email protected]> * fix: package version to 1.4.2 (#700) Signed-off-by: Jason Porter <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: project settings dashbboard tests (#701) * fix: project settings dashbboard tests Signed-off-by: 4nalog <[email protected]> * chore: remove .only Signed-off-by: 4nalog <[email protected]> * refactor: remove empty waitFor Signed-off-by: 4nalog <[email protected]> --------- Signed-off-by: 4nalog <[email protected]> * fix: upgrading node version to 18 (#703) Upgrading node version to 18 Signed-off-by: Jason Porter <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: revert node version (#704) * fix: revert node version Signed-off-by: Carina Ursu <[email protected]> * Revert "fix: upgrading node version to 18 (#703)" This reverts commit e5f9a8b. Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: deployment optimization (#706) * fix: deployment optimization Signed-off-by: Carina Ursu <[email protected]> * clean up node modules and one file that we think is not needed Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> * fix: upgrade release node version (#707) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: update chalk, add semantic-release test cmd (#708) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: implement logic to handle multiple keys for nested data classes Signed-off-by: 4nalog <[email protected]> * chore: fix update_npmversion (#709) * chore: fix update_npmversion Signed-off-by: Carina Ursu <[email protected]> * chore: edits Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * Mapped Tasks not showing cache status correctly. (#712) * fix: cache status logs indexing mismatch and react rendering cycle issue Signed-off-by: James <[email protected]> * fix: mapped task cache status Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: cleanup, passthrough runtime variables (#710) fix: passthrough runtime variables Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: update_npmversion (#713) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: fix sed makefile error (#714) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * FE: Update flyteconsole to Node 18 (#717) fix: nodejs 18 upgrade Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: allow complex workflow names (#715) * chore: allow complex workflow names Signed-off-by: Carina Ursu <[email protected]> * chore: fix buold:watch Signed-off-by: Carina Ursu <[email protected]> * chore: yarn.lock Signed-off-by: Carina Ursu <[email protected]> * chore: upgrade package Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> * chore: show correct app version in info (#716) * chore: show correct app version in info Signed-off-by: Carina Ursu <[email protected]> * chore: update ver Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: left nav doesn't accurately update on workflow version page (#718) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * feat: differentiate between cache disabled and cache put failure (#719) fix: add icon for put failure Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: fix formatting Signed-off-by: 4nalog <[email protected]> * fix: add material-ui class name seed (#721) * chore: add material-ui class name seed Signed-off-by: Carina Ursu <[email protected]> * fix: overflow of modal Signed-off-by: James <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: James <[email protected]> Co-authored-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * The rendering of node status in a dynamic workflow is not functioning correctly (#723) fix: dynamic nodes status Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: backfill index on execution task logs (#725) * chore: backfill index on execution task logs Signed-off-by: Carina Ursu <[email protected]> * chore: add comments Signed-off-by: Carina Ursu <[email protected]> * chore: bump version Signed-off-by: Carina Ursu <[email protected]> * chore: remove backfill Signed-off-by: Carina Ursu <[email protected]> * chore: lint Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: release fail (#726) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * Install deps directly in checks.yml (#728) Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: show correct i/o in details panel (#727) * chore: show correct i/o in details panel Signed-off-by: Carina Ursu <[email protected]> * chore: bump version Signed-off-by: Carina Ursu <[email protected]> * chore: feedback Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: task observability (#720) * chore: tlro basic setup Signed-off-by: Carina Ursu <[email protected]> * progress checkin * Stable state refactored to use generic naming * updated types * working before updating routes * chore: progress Signed-off-by: Carina Ursu <[email protected]> * chore: remove debugger Signed-off-by: Carina Ursu <[email protected]> * chore: allow custom class in execution actions Signed-off-by: Carina Ursu <[email protected]> * chore: lint fix Signed-off-by: Carina Ursu <[email protected]> * chore: bump console Signed-off-by: Carina Ursu <[email protected]> * chore: up package version Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Jason Porter <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: fix contextual menu action buttons color (#730) * chore: fix contextual menu action buttons color Signed-off-by: Carina Ursu <[email protected]> * chore: up console version Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * chore: add build:watch to all packages (#731) Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * Add REJECT support for ApprovedCondition for GateNodes (#733) * fix: approveCondition reject Signed-off-by: James <[email protected]> * fix: approve button Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Signed-off-by: 4nalog <[email protected]> * gate node in dynamic task (#729) * fix: gate node in dynamic Signed-off-by: James <[email protected]> * fix: upgraded version Signed-off-by: James <[email protected]> * fix: compiledNode in PausedTasksComponent and ExecutionDetailsActions Signed-off-by: James <[email protected]> * fix: upgrade version Signed-off-by: James <[email protected]> * chore: lockfile Signed-off-by: Carina Ursu <[email protected]> * fix: remove caching for workflow closure Signed-off-by: James <[email protected]> * fix: break link between cache and context state Signed-off-by: James <[email protected]> --------- Signed-off-by: James <[email protected]> Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Signed-off-by: 4nalog <[email protected]> * fix: comments Signed-off-by: 4nalog <[email protected]> --------- Signed-off-by: 4nalog <[email protected]> Signed-off-by: James <[email protected]> Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: james-union <[email protected]> Co-authored-by: Jason Porter <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Co-authored-by: James <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]> Co-authored-by: Jason Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#3430 (comment)
I've added this icon (pointing with red)
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes flyteorg/flyte#3430