gate node in dynamic task

[james-union]

flyteorg/flyte#3354

How to reproduce

flytesnacks/development/human_in_the_loop.wf_dyn

Launch the above workflow and it should show Paused for gate nodes.

How to fix

Dynamic nodes are included in subWorkflows under compiledWorkflowClosure instead of primary. We only considered priamry to check the compiled nodes and that's why the ui couldn't understand the gate nodes.

Another issue was that compiled nodes are not only based on execution node id. We should also compare with the metadata.specNodeId

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes flyteorg/flyte#3354

[codecov]

Codecov Report

Merging #729 (f3339c9) into master (6ebd69f) will increase coverage by 0.13%.
The diff coverage is 80.48%.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   66.61%   66.74%   +0.13%     
==========================================
  Files         464      464              
  Lines       11370    11388      +18     
  Branches     2094     2102       +8     
==========================================
+ Hits         7574     7601      +27     
+ Misses       3796     3787       -9     

Impacted Files	Coverage Δ
...ponents/Executions/Tables/nodeExecutionColumns.tsx	31.81% <0.00%> (-0.49%)	⬇️
...ents/flytegraph/ReactFlow/customNodeComponents.tsx	19.18% <25.00%> (+0.47%)	⬆️
...s/flytegraph/ReactFlow/ReactFlowGraphComponent.tsx	52.00% <50.00%> (+0.48%)	⬆️
...ponents/Executions/Tables/NodeExecutionActions.tsx	89.70% <80.00%> (-1.34%)	⬇️
packages/console/src/components/hooks/utils.ts	94.44% <83.33%> (-5.56%)	⬇️
...tions/ExecutionDetails/ExecutionDetailsActions.tsx	82.60% <100.00%> (+0.79%)	⬆️
...cutionDetails/NodeExecutionDetailsPanelContent.tsx	81.57% <100.00%> (+0.19%)	⬆️
...mponents/Executions/Tables/NodeExecutionsTable.tsx	91.80% <100.00%> (+0.13%)	⬆️
...ons/contextProvider/NodeExecutionDetails/index.tsx	72.85% <100.00%> (+0.39%)	⬆️
...ackages/console/src/components/Executions/utils.ts	68.75% <100.00%> (-0.28%)	⬇️
... and 1 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ursucarina]

@james-union 2 things:

• clicking Resume doesn't do anything, because 'compiledNode' is undefined. Is this expected?
• can you please up the package version
• please remember to sign off on all your commits git commit --amend --signoff

[jsonporter]

This PR fixes identifying gate nodes however I don't think we can merge this without the other fix for [BUG] Flyteconsole: status of gate nodes does not update without refresh #3524 and #3443 because the experience is still broken.

[jsonporter]

While this does work in fixing the issue where the graph errantly shows the nested contents (when it should instead show the grey-subworkflow button; see image) however I don't think this is right place to make the fix because these values will be immutable meaning we should not be invalidating the request cache. That said - I agree that this is likely a caching issue, just not here

correct:

[flyte-bot]

🎉 This PR is included in version 1.5.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀