Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow versions table v2 #200

Merged
merged 9 commits into from
Sep 16, 2021
Merged

Workflow versions table v2 #200

merged 9 commits into from
Sep 16, 2021

Conversation

govalt
Copy link
Contributor

@govalt govalt commented Sep 14, 2021

TL;DR

Implements new version of data table for workflow versions as a generalized one.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Added PaginatedDataList component
  • Changed original implementation for DataList react-virtualized based component

Tracking Issue

implements flyteorg/flyte#1386

Follow-up issue

NA

@govalt govalt changed the title Feat/version table Workflow versions table v2 Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@f09f6af). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #200   +/-   ##
=========================================
  Coverage          ?   64.70%           
=========================================
  Files             ?      357           
  Lines             ?     7560           
  Branches          ?     1308           
=========================================
  Hits              ?     4892           
  Misses            ?     2668           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09f6af...6cfee68. Read the comment docs.

Pianist038801
Pianist038801 previously approved these changes Sep 15, 2021
Copy link
Contributor

@Pianist038801 Pianist038801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jsonporter jsonporter merged commit a890e72 into master Sep 16, 2021
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.25.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anrusina anrusina deleted the feat/version-table branch January 13, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants