Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: remove redundant docker build on merge to master" #392

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Apr 15, 2022

Reverts #390

sequence of steps is

  1. build image successfully
  2. release flyteconsole
  3. build & push image

@katrogan katrogan requested a review from yindia April 15, 2022 16:03
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #392 (2aaa52e) into master (46db242) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files         405      405           
  Lines        9063     9063           
  Branches     1600     1600           
=======================================
  Hits         6021     6021           
  Misses       3042     3042           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46db242...2aaa52e. Read the comment docs.

@katrogan katrogan merged commit fb564f3 into master Apr 15, 2022
@katrogan katrogan deleted the revert-390-build-and-push-duplicate branch April 15, 2022 16:19
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.52.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants