Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merge devmain into master #patch #474 #476

Closed
wants to merge 26 commits into from
Closed

Conversation

anrusina
Copy link
Contributor

This PR will merge changes done in devMain branch into master, to publish new flyteconsole v.1.1.0 .
I'm marking it as a Fix As I'm not sure how the version will be bumped, and the project.json already contains v.1.1.0-rc1 version value.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

refactor: https://github.com/flyteorg/flyteconsole/issues/431 Move to monorepo structure to allow separate FlyteConsole into plugins system

feat: https://github.com/flyteorg/flyteconsole/issues/414 Add support for StructuredDataSet Input/Output type
feat: #445 Update Input/Output and TaskDetails representation - now you can collapse parts of it.
feat: https://github.com/flyteorg/flyteconsole/issues/311 Show new map tasks in the GraphView with information of which subtasks are in which phase(running, erroring, succeeded)

fix: https://github.com/flyteorg/flyteconsole/issues/463 ensure that setups with different domains for console and admin API properly works
fix: https://github.com/flyteorg/flyteconsole/issues/416 Fixes one of the crashes in Graph component for Viel All Workflow section
fix: ensure that admin version is fully shown #465
fix: Small cosmetic updates: #451, https://github.com/flyteorg/flyteconsole/issues/386, https://github.com/flyteorg/flyteconsole/issues/398

anrusina and others added 26 commits May 17, 2022 12:21
Signed-off-by: Nastya Rusina <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
* ci: move storybook related packages to top level
* ci: ensure that lint can be run in PR checks
* ci: allow to run tests linux setup

Signed-off-by: Nastya Rusina <[email protected]>
#436)

* ci: ensure unified tsconfig and remove mocks,test,stories from build
* ci: move certificates into certificate folder inside script

Signed-off-by: Nastya Rusina <[email protected]>
* fix: issue 398
* fix: prevent parent onclick event trigger

Signed-off-by: eugenejahn <[email protected]>
* fix: unable to view all the workflow versions

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
* chore(tsc): exclude test/stories/mock files only from build

Signed-off-by: Nastya Rusina <[email protected]>
* chore: support for StructuredDataSet Input/Output type

Signed-off-by: Carina Ursu <[email protected]>

* chore: add tests

Signed-off-by: Carina Ursu <[email protected]>

* chore: add package

Signed-off-by: Carina Ursu <[email protected]>

* chore: resolving local package issue

Signed-off-by: Carina Ursu <[email protected]>

* chore: yarn lock

Signed-off-by: Carina Ursu <[email protected]>

* chore: stories

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix associative arrays in copy functionality

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix scalar stories

Signed-off-by: Carina Ursu <[email protected]>

* chore: oops

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: revert old viewer to original

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix

Signed-off-by: Carina Ursu <[email protected]>

* chore: remove non-null assertion

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix types

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix tests

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix test types

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
…scode setup properly (#458)

* chore: separate AppInfo
* chore: vscode properly understands @flyteconsole
* chore: add basics/locale entry
* test: add storybooks and tests
* test: fix istanbul test-coverage issue by binding babel versions

Signed-off-by: Nastya Rusina <[email protected]>
* ci: minimize babel presence

Signed-off-by: Nastya Rusina <[email protected]>
* fix: update node executions to display map tasks
* fix: update map task logs styles
* test: add/update unit tests
* fix: fix flickering and unnecessary re-renders

Signed-off-by: Olga Nad <[email protected]>
* ci: resolve docker build issues
* chore: remove unneeded changes

Signed-off-by: Nastya Rusina <[email protected]>
* chore: fix

Signed-off-by: Carina Ursu <[email protected]>

* chore: remove console

Signed-off-by: Carina Ursu <[email protected]>

* chore: add cherio o=to package

Signed-off-by: Carina Ursu <[email protected]>

* chore: add cherio o=to package

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix start prod

Signed-off-by: Carina Ursu <[email protected]>

* chore: fix start prod

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

* chore: cleanup

Signed-off-by: Carina Ursu <[email protected]>

Co-authored-by: Carina Ursu <[email protected]>
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #476 (4e123d9) into master (919e90c) will increase coverage by 0.09%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
+ Coverage   67.18%   67.27%   +0.09%     
==========================================
  Files         413      405       -8     
  Lines        9295     9465     +170     
  Branches     1630     1606      -24     
==========================================
+ Hits         6245     6368     +123     
- Misses       3050     3097      +47     
Impacted Files Coverage Δ
...zapp/console/src/basics/FeatureFlags/AdminFlag.tsx 94.11% <ø> (ø)
...p/console/src/basics/FeatureFlags/FeatureFlags.tsx 93.54% <ø> (ø)
...p/console/src/basics/FeatureFlags/defaultConfig.ts 100.00% <ø> (ø)
...ges/zapp/console/src/basics/FeatureFlags/index.tsx 100.00% <ø> (ø)
.../console/src/basics/LocalCache/ContextProvider.tsx 89.65% <ø> (ø)
...app/console/src/basics/LocalCache/defaultConfig.ts 100.00% <ø> (ø)
...kages/zapp/console/src/basics/LocalCache/index.tsx 100.00% <ø> (ø)
...ole/src/basics/LocalCache/onlyMineDefaultConfig.ts 100.00% <ø> (ø)
packages/zapp/console/src/common/constants.ts 100.00% <ø> (ø)
packages/zapp/console/src/common/env.ts 100.00% <ø> (ø)
... and 685 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 919e90c...4e123d9. Read the comment docs.

@anrusina anrusina closed this May 17, 2022
@anrusina anrusina deleted the narusina/rebase_2 branch May 18, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants