Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard pull request template for Console #51

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Mar 10, 2020

TL;DR

Adds flyte wide standard pull request template for Console

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

updated using boilerplate

Tracking Issue

flyteorg/flyte#194

Follow-up issue

NA

@kumare3 kumare3 requested a review from schottra March 10, 2020 00:34
@schottra
Copy link
Contributor

schottra commented Mar 10, 2020

@kumare3 Should this PR also have included the pull_request_template.md file?

@kumare3 kumare3 merged commit 453c6a9 into master Mar 10, 2020
@kumare3
Copy link
Contributor Author

kumare3 commented Mar 10, 2020

oops i saw your comment later

@schottra schottra deleted the pull_request_template branch June 1, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants