Executions View

.eslintrc.js

@@ -85,6 +85,7 @@ module.exports = {
     'no-await-in-loop': 'off',
     'no-undef-init': 'off',
     'no-unneeded-ternary': 'off',
+    'no-underscore-dangle': 'off',
     'prefer-object-spread': 'off',
     'prefer-template': 'off',
     'default-case': 'off',

.github/workflows/checks.yml

@@ -12,14 +12,14 @@ on:
       - devmain
 
 jobs:
-  extraxt_branch:
+  extract_branch:
     runs-on: ubuntu-latest
     outputs:
-      currentTag: ${{ steps.extract_branch.outputs.extract_branch }}
+      branch: ${{ steps.extract_branch.outputs.branch }}
     steps:
       - name: Extract branch name
         shell: bash
-        run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/})"
+        run: echo "::set-output name=branch::$(echo ${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}})"
         id: extract_branch
 
   unit_tests_with_coverage:
@@ -66,7 +66,7 @@ jobs:
   release:
     name: Generate Release
     if: ${{ (github.event_name != 'pull_request') && (needs.extract_branch.outputs.branch == 'master') }}
-    needs: [unit_tests_with_coverage, lint_project, build_docker_image, extraxt_branch]
+    needs: [unit_tests_with_coverage, lint_project, build_docker_image, extract_branch]
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -107,17 +107,32 @@ jobs:
         # a tag, update our target
         run: |
           CURRENT_TAG=$(git tag --sort=-refname --points-at ${{ github.ref }} | head -n 1)
+          echo $CURRENT_TAG
           echo "::set-output name=currentTag::$CURRENT_TAG"
 
   push_docker_image:
-    name: Build & Push Flyteconsole Image
+    name: Push to Github Registry
     needs: [check_for_tag]
-    uses: flyteorg/flytetools/.github/workflows/publish.yml@master
-    with:
-      version: ${{ needs.check_for_tag.outputs.currentTag }}
-      dockerfile: Dockerfile
-      push: true
-      repository: ${{ github.repository }}
-    secrets:
-      FLYTE_BOT_PAT: ${{ secrets.FLYTE_BOT_PAT }}
-      FLYTE_BOT_USERNAME: ${{ secrets.FLYTE_BOT_USERNAME }}
+    runs-on: ubuntu-latest
+    if: ${{ needs.check_for_tag.outputs.currentTag != '' }}
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: '0'
+      - name: Autobump version
+        env:
+          TAG: ${{ needs.check_for_tag.outputs.currentTag }}
+        run: |
+          VERSION=${TAG:1} make update_npmversion
+      - name: Push Docker Image to Github Registry
+        uses: whoan/docker-build-with-cache-action@v5
+        with:
+          username: "${{ secrets.FLYTE_BOT_USERNAME }}"
+          password: "${{ secrets.FLYTE_BOT_PAT }}"
+          image_name: flyteorg/flyteconsole
+          image_tag: latest,${{ github.sha }},${{ needs.check_for_tag.outputs.currentTag }}
+          push_git_tag: true
+          push_image_and_stages: true
+          dockerfile: Dockerfile
+          registry: ghcr.io
+          build_extra_args: "--compress=true"

.github/workflows/upgrade_automtion.yml → .github/workflows/upgrade_automation.yml

@@ -10,10 +10,11 @@ on:
         options:
           - boilerplate
           - flyteidl
+          - flyteconsole
 jobs:
   trigger-upgrade:
     name: ${{ github.event.inputs.component }} Upgrade
-    if: ${{ github.event.inputs.component  == "boilerplate" }}
+    if: ${{ github.event.inputs.component  == 'boilerplate' }}
     uses: flyteorg/flytetools/.github/workflows/flyte_automation.yml@master
     with:
       component: ${{ github.event.inputs.component }}
@@ -23,7 +24,7 @@ jobs:
   upgrade_flyteidl:
     name: Upgrade Flyteidl
     runs-on: ubuntu-latest
-    if: ${{ github.event.inputs.component  == "boilerplate" }}
+    if: ${{ github.event.inputs.component  == 'flyteidl' }}
     steps:
       - uses: actions/checkout@v2
         with:
@@ -47,7 +48,7 @@ jobs:
           signoff: true
           branch: flyte-bot-update-flyteidl
           delete-branch: true
-          title: 'Update Flyteidl version'
+          title: "Update Flyteidl version"
           body: |
             Update Flyteidl version
             - Auto-generated by [flyte-bot]
@@ -57,3 +58,4 @@ jobs:
             owners
             maintainers
           draft: false
+

.gitignore

@@ -40,6 +40,7 @@ app/public/styles/*.css
 .idea
 .cache/
 venv/
+*.tsbuildinfo
 
 # Frontend
 .awcache/
@@ -52,7 +53,4 @@ yarn-error.log
 
 # Certs
 .srl
-script/rootCA.*
-script/server.crt
-script/server.csr
-script/server.key
+certificate/

.releaserc.json

@@ -9,13 +9,6 @@
             }
         ],
         ["@semantic-release/npm", { "npmPublish": false }],
-        "@semantic-release/github",
-        [
-            "@semantic-release/git",
-            {
-                "assets": ["package.json", "CHANGELOG.md"],
-                "message": "chore(release): Release ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}"
-            }
-        ]
+        "@semantic-release/github"
     ]
 }

.storybook/StorybookContainer.tsx

@@ -6,11 +6,11 @@ import { QueryClientProvider } from 'react-query';
 import { MemoryRouter } from 'react-router-dom';
 import { SnackbarProvider } from 'notistack';
 
-import { ErrorBoundary } from '../src/components/common/ErrorBoundary';
-import { createQueryClient } from '../src/components/data/queryCache';
-import { muiTheme } from '../src/components/Theme/muiTheme';
-import { LocalCacheProvider } from '../src/basics/LocalCache/ContextProvider';
-import { FeatureFlagsProvider } from '../src/basics/FeatureFlags';
+import { ErrorBoundary } from '../packages/zapp/console/src/components/common/ErrorBoundary';
+import { createQueryClient } from '../packages/zapp/console/src/components/data/queryCache';
+import { muiTheme } from '../packages/zapp/console/src/components/Theme/muiTheme';
+import { LocalCacheProvider } from '../packages/zapp/console/src/basics/LocalCache/ContextProvider';
+import { FeatureFlagsProvider } from '../packages/zapp/console/src/basics/FeatureFlags';
 
 const useStyles = makeStyles((theme: Theme) => ({
   container: {

.storybook/main.js

@@ -1,16 +1,17 @@
+var path = require('path');
 module.exports = {
   core: {
     builder: 'webpack5',
   },
-  stories: ['../src/**/*.stories.mdx', '../src/**/*.stories.@(js|jsx|ts|tsx)'],
+  stories: ['../packages/**/*.stories.@(js|jsx|ts|tsx|mdx)'],
   addons: [
     '@storybook/addon-links',
     '@storybook/addon-essentials',
     '@storybook/addon-interactions',
   ],
   framework: '@storybook/react',
   webpackFinal: async (config, { configType }) => {
-    config.resolve.modules = ['src', 'node_modules'];
+    config.resolve.modules = ['packages/zapp/console/src', 'node_modules'];
     config.module.rules = [
       ...config.module.rules,
       {
@@ -22,6 +23,15 @@ module.exports = {
         use: ['babel-loader', { loader: 'ts-loader', options: { transpileOnly: true } }],
       },
     ];
+
+    config.resolve.alias = {
+      ...config.resolve.alias,
+      '@flyteconsole/locale': path.resolve(__dirname, '../packages/basics/locale/src'),
+      '@flyteconsole/ui-atoms': path.resolve(__dirname, '../packages/composites/ui-atoms/src'),
+      '@flyteconsole/components': path.resolve(__dirname, '../packages/plugins/components/src'),
+      '@flyteconsole/flyte-api': path.resolve(__dirname, '../packages/plugins/flyte-api/src'),
+    };
+
     return config;
   },
 };

.vscode/launch.json

@@ -0,0 +1,16 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "launch generator",
+            "type": "node",
+            "request": "launch",
+            "skipFiles": ["<node_internals>/**"],
+            "program": "${workspaceFolder}/script/generator/src/index.js",
+            "console": "integratedTerminal"
+        }
+    ]
+}

CONTRIBUTING.md

@@ -22,6 +22,30 @@ a single module, you can specify that one specifically
 (ex. `localStorage.debug = 'flyte:adminEntity'` to only see decoded Flyte
 Admin API requests).
 
+## Generate new package
+
+To add a new package use a script
+
+```bash
+yarn generate:package
+```
+
+After new package is generated, you will need to update some values to be able to use it with other packages.
+For example in case if package plan to be used in `console` app
+
+Ensure to add proper webpack alias path resolutions into:
+* ./storybook/main.js -  as `'@flyteconsole/flyte-api': path.resolve(__dirname, '../packages/plugins/flyte-api/src’),`
+* packages/zapp/console/webpack.common.config.ts to alias section -  as `'@flyteconsole/flyte-api': path.resolve(__dirname, '../packages/plugins/flyte-api/src’),`
+
+To add child package usage to other package, in parent package ->
+* Add `{ "path": “../../${type}/${package-name}" }` to tsconfig.json
+* Add `{ "path": “../../${type}/${package-name}/tsconfig.build.json" }` to tsconfig.build.json (if exists)
+- Then you can import your changes as `import { getLoginUrl } from '@flyteconsole/flyte-api’;`
+
+> If you see `yarn lint` package not defined issues update `.\eslintrc.js` by adding your package to 
+    'import/core-modules': ['@clients/locale', '@clients/primitives', '@clients/theme'],
+
+
 ## Storybook
 
 This project has support for [Storybook](https://storybook.js.org/).
@@ -115,9 +139,10 @@ brew install asdf
 brew install vips
 ```
 
--   Add Yarn plugin to asdf, to manage yarn versions
+-   Add Yarn and NodeJs plugins to asdf, to manage versions
 
 ```bash
+asdf plugin add nodejs https://github.com/asdf-vm/asdf-nodejs.git
 asdf plugin-add yarn https://github.com/twuni/asdf-yarn.git
 brew install gpg
 ```

Dockerfile

@@ -1,8 +1,9 @@
+# Use node:17 to docker build on M1
 FROM node:16 as builder
-LABEL org.opencontainers.image.source https://github.com/lyft/flyteconsole
+LABEL org.opencontainers.image.source https://github.com/flyteorg/flyteconsole
 
 WORKDIR /code/flyteconsole
-COPY package*.json yarn.lock ./
+COPY ./packages/zapp/console/package*.json yarn.lock ./
 RUN : \
   # install production dependencies
   && yarn install --production \
@@ -17,10 +18,11 @@ RUN : \
   # build
   && make build_prod \
   # place the runtime application in /app
-  && mv dist index.js env.js plugins.js /app
+  && mv ./packages/zapp/console/dist /app \
+  && mv ./packages/zapp/console/index.js ./packages/zapp/console/env.js ./packages/zapp/console/plugins.js /app
 
 FROM gcr.io/distroless/nodejs
-LABEL org.opencontainers.image.source https://github.com/lyft/flyteconsole
+LABEL org.opencontainers.image.source https://github.com/flyteorg/flyteconsole
 
 COPY --from=builder /app app
 WORKDIR /app

Makefile

@@ -42,3 +42,10 @@ test_unit_codecov:
 .PHONY: generate_ssl
 generate_ssl:
 	./script/generate_ssl.sh
+
+PLACEHOLDER_NPM := \"version\": \"0.0.0-develop\"
+
+.PHONY: update_npmversion
+update_npmversion:
+	grep "$(PLACEHOLDER_NPM)" "packages/zapp/console/package.json"
+	sed -i "s/$(PLACEHOLDER_NPM)/\"version\":  \"${VERSION}\"/g" "packages/zapp/console/package.json"