Merge current master into devmain #606

olga-union · 2022-09-30T21:54:57Z

TL;DR

Merge current master into devmain.

Type

Bug Fix
Feature
Plugin
Chore

Are all requirements met?

Follow-up issue

NA

Signed-off-by: Nastya Rusina <[email protected]>

Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

Signed-off-by: eugenejahn <[email protected]>

* ci: move storybook related packages to top level * ci: ensure that lint can be run in PR checks * ci: allow to run tests linux setup Signed-off-by: Nastya Rusina <[email protected]>

Signed-off-by: eugenejahn <[email protected]>

#436) * ci: ensure unified tsconfig and remove mocks,test,stories from build * ci: move certificates into certificate folder inside script Signed-off-by: Nastya Rusina <[email protected]>

* fix: issue 398 * fix: prevent parent onclick event trigger Signed-off-by: eugenejahn <[email protected]>

* fix: unable to view all the workflow versions Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

* chore(tsc): exclude test/stories/mock files only from build Signed-off-by: Nastya Rusina <[email protected]>

Signed-off-by: Nastya Rusina <[email protected]>

* chore: support for StructuredDataSet Input/Output type Signed-off-by: Carina Ursu <[email protected]> * chore: add tests Signed-off-by: Carina Ursu <[email protected]> * chore: add package Signed-off-by: Carina Ursu <[email protected]> * chore: resolving local package issue Signed-off-by: Carina Ursu <[email protected]> * chore: yarn lock Signed-off-by: Carina Ursu <[email protected]> * chore: stories Signed-off-by: Carina Ursu <[email protected]> * chore: fix associative arrays in copy functionality Signed-off-by: Carina Ursu <[email protected]> * chore: fix scalar stories Signed-off-by: Carina Ursu <[email protected]> * chore: oops Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: revert old viewer to original Signed-off-by: Carina Ursu <[email protected]> * chore: fix Signed-off-by: Carina Ursu <[email protected]> * chore: remove non-null assertion Signed-off-by: Carina Ursu <[email protected]> * chore: fix types Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: fix tests Signed-off-by: Carina Ursu <[email protected]> * chore: fix test types Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

…scode setup properly (#458) * chore: separate AppInfo * chore: vscode properly understands @flyteconsole * chore: add basics/locale entry * test: add storybooks and tests * test: fix istanbul test-coverage issue by binding babel versions Signed-off-by: Nastya Rusina <[email protected]>

* ci: minimize babel presence Signed-off-by: Nastya Rusina <[email protected]>

* fix: update node executions to display map tasks * fix: update map task logs styles * test: add/update unit tests * fix: fix flickering and unnecessary re-renders Signed-off-by: Olga Nad <[email protected]>

* ci: resolve docker build issues * chore: remove unneeded changes Signed-off-by: Nastya Rusina <[email protected]>

* chore: fix Signed-off-by: Carina Ursu <[email protected]> * chore: remove console Signed-off-by: Carina Ursu <[email protected]> * chore: add cherio o=to package Signed-off-by: Carina Ursu <[email protected]> * chore: add cherio o=to package Signed-off-by: Carina Ursu <[email protected]> * chore: fix start prod Signed-off-by: Carina Ursu <[email protected]> * chore: fix start prod Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

Signed-off-by: Nastya <[email protected]>

made the entities component become more generic that can support Workflow, Task, and others added the inputs and outputs to task details page added the versions table in task details page added the version details page added task details link in node side panel Signed-off-by: eugenejahn <[email protected]> Co-authored-by: Eugene Jahn <[email protected]>

Signed-off-by: Nastya Rusina <[email protected]> Co-authored-by: Nastya Rusina <[email protected]>

* hotfix ci pipeline Signed-off-by: Yuvraj <[email protected]> * more changes Signed-off-by: Yuvraj <[email protected]> Co-authored-by: Yuvraj <[email protected]>

Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

chore: fix searchbar X button Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

#562) * fix: update timeline view to show dynamic wf internals on first render Signed-off-by: Olga Nad <[email protected]> * fix: update tests and clean up code Signed-off-by: Olga Nad <[email protected]> * fix: test Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

* fix: console showing subworkflows as unknown Signed-off-by: Olga Nad <[email protected]> * fix: replace comparison with lodash isEqual Signed-off-by: Olga Nad <[email protected]> * fix: remove checkIfObjectsAreSame Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>

fix: dict lose trailing issue Signed-off-by: James <[email protected]> Signed-off-by: James <[email protected]>

* fix: disable launch button and show validation messaages Signed-off-by: James <[email protected]> * fix: code clean Signed-off-by: James <[email protected]> Signed-off-by: James <[email protected]>

…572) * fix: integrate timeline and graph tabs wrappers under one component Signed-off-by: Olga Nad <[email protected]> * fix: details tab in graph view and clean-up Signed-off-by: Olga Nad <[email protected]> * fix: old unit tests Signed-off-by: Olga Nad <[email protected]> * fix: temp filename change Signed-off-by: Olga Nad <[email protected]> * fix: final filename change Signed-off-by: Olga Nad <[email protected]> * fix: tsconfig Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>

Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.3...2.29.4) --- updated-dependencies: - dependency-name: moment dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* added none type in union type Signed-off-by: eugenejahn <[email protected]> * udpated the test case Signed-off-by: eugenejahn <[email protected]> * fix: fixed eslint Signed-off-by: eugenejahn <[email protected]> Signed-off-by: eugenejahn <[email protected]>

#578) fix: correctly coerce defaultValue when rendering LaunchPlan details Signed-off-by: Rahul Mehta <[email protected]> Signed-off-by: Rahul Mehta <[email protected]>

fix: inputHelpers InputProps Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

* fix: fix test of launchform Signed-off-by: James <[email protected]> * fix: inputHelpers tests regression Signed-off-by: Olga Nad <[email protected]> * fix: update tests description Signed-off-by: Olga Nad <[email protected]> * fix: spelling typo Signed-off-by: Olga Nad <[email protected]> Signed-off-by: James <[email protected]> Signed-off-by: Olga Nad <[email protected]> Co-authored-by: Olga Nad <[email protected]>

Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

Minor change Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

…#582) Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

* fix: add BASE_URL to dev startup, open deeply nested urls Signed-off-by: Carina Ursu <[email protected]> * fix: remove debug code Signed-off-by: Carina Ursu <[email protected]> * chore: empty BASE_URL handling Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

* fix: add default disabled state for only mine filter Signed-off-by: Olga Nad <[email protected]> * fix: tests Signed-off-by: Olga Nad <[email protected]> * fix: use api context to default filter state Signed-off-by: Olga Nad <[email protected]> * fix: revert test updates Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

* progress * Fixed * Removed debug code Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

chore: enable deeplinks in development Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

…o devmain

codecov · 2022-09-30T22:11:15Z

Codecov Report

Merging #606 (2139738) into devmain (d38b98b) will decrease coverage by 2.26%.
The diff coverage is 45.62%.

@@             Coverage Diff             @@
##           devmain     #606      +/-   ##
===========================================
- Coverage    71.05%   68.79%   -2.27%     
===========================================
  Files          426      442      +16     
  Lines         9849    10478     +629     
  Branches      1673     1796     +123     
===========================================
+ Hits          6998     7208     +210     
- Misses        2851     3270     +419

Impacted Files	Coverage Δ
...le/src/components/Entities/EntityDetailsHeader.tsx	`86.11% <ø> (ø)`
...nsole/src/components/Entities/EntityExecutions.tsx	`96.77% <ø> (-0.29%)`	⬇️
...s/VersionDetails/EntityVersionDetailsContainer.tsx	`0.00% <0.00%> (ø)`
.../zapp/console/src/components/Entities/constants.ts	`100.00% <ø> (ø)`
...es/zapp/console/src/components/Entities/strings.ts	`100.00% <ø> (ø)`
...cutionDetails/NodeExecutionDetailsPanelContent.tsx	`91.48% <ø> (ø)`
...cutions/ExecutionDetails/RelaunchExecutionForm.tsx	`100.00% <ø> (ø)`
...ls/TaskExecutionNodeRenderer/TaskExecutionNode.tsx	`0.00% <0.00%> (ø)`
...Executions/ExecutionDetails/Timeline/taskNames.tsx	`0.00% <ø> (-60.00%)`	⬇️
...components/Executions/ExecutionDetails/strings.tsx	`100.00% <ø> (ø)`
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

anrusina and others added 30 commits May 17, 2022 18:05

chore: move src to a new location

286e1f8

Signed-off-by: Nastya Rusina <[email protected]>

ci: allow branch to be built again

0efd1df

Signed-off-by: Nastya Rusina <[email protected]>

chore: replace link to github repository to a proper one

b49fed5

Signed-off-by: Nastya Rusina <[email protected]>

ci: basic test and test-coverage setup

9503a4c

Signed-off-by: Nastya Rusina <[email protected]>

chore: add first plugin package

3091c4b

Signed-off-by: Nastya Rusina <[email protected]>

chore: allow to start test from main directory

3573659

Signed-off-by: Nastya Rusina <[email protected]>

ci: update lowest mkdirp version (#423)

8d1fef9

Signed-off-by: Nastya Rusina <[email protected]>

chore: add build scripts for console app (#429)

48a1c92

Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

fix: hide the legend (#435)

caaf5c2

Signed-off-by: eugenejahn <[email protected]>

ci: move storybook related packages to top level (#434)

133038a

* ci: move storybook related packages to top level * ci: ensure that lint can be run in PR checks * ci: allow to run tests linux setup Signed-off-by: Nastya Rusina <[email protected]>

fix: fix issue 386 (#437)

1651a6f

Signed-off-by: eugenejahn <[email protected]>

ci: ensure unified tsconfig and remove mocks, test, stories from build (

eeb551b

#436) * ci: ensure unified tsconfig and remove mocks,test,stories from build * ci: move certificates into certificate folder inside script Signed-off-by: Nastya Rusina <[email protected]>

Make whole row clickable to open TaskExecutionDetails panel (#444)

b6e9941

* fix: issue 398 * fix: prevent parent onclick event trigger Signed-off-by: eugenejahn <[email protected]>

ci: allow to start jest config for all project at once (#447)

b513280

minor: unable to view all the workflow versions (#446)

ecfdd4c

* fix: unable to view all the workflow versions Signed-off-by: Carina Ursu <[email protected]> * chore: cleanup Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>

chore(tsc): exclude test/stories/mock files only from build (#451)

5b44539

* chore(tsc): exclude test/stories/mock files only from build Signed-off-by: Nastya Rusina <[email protected]>

ci: ensure that webpack too doesn't include test/mock/specs files (#452)

560b645

Signed-off-by: Nastya Rusina <[email protected]>

ci: minimize babel presence (#457)

acf3cb9

* ci: minimize babel presence Signed-off-by: Nastya Rusina <[email protected]>

fix: update node executions to display map tasks (#455)

38a4e96

* fix: update node executions to display map tasks * fix: update map task logs styles * test: add/update unit tests * fix: fix flickering and unnecessary re-renders Signed-off-by: Olga Nad <[email protected]>

ci: resolve docker build issues (#462)

c2ee154

* ci: resolve docker build issues * chore: remove unneeded changes Signed-off-by: Nastya Rusina <[email protected]>

Chore: Rebase devmain on top of master (#464)

e84a3c0

fix: ensure that admin version is fully shown (#465)

0853680

chore: rebase on top of master

1859cf5

Signed-off-by: Nastya <[email protected]>

fix: trigger release #patch (#477)

42d2632

Signed-off-by: Nastya <[email protected]>

chore: update Readme with python note + package version update (#486)

821299e

Signed-off-by: Nastya Rusina <[email protected]> Co-authored-by: Nastya Rusina <[email protected]>

hotfix ci pipeline (#487)

c25daea

* hotfix ci pipeline Signed-off-by: Yuvraj <[email protected]> * more changes Signed-off-by: Yuvraj <[email protected]> Co-authored-by: Yuvraj <[email protected]>

yindia and others added 26 commits July 25, 2022 19:07

enable docker push for console (#552)

16d70a9

Update Flyteidl version (#558)

3f2bbfb

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

fix: fix searchbar X button (#564)

1f89e2b

chore: fix searchbar X button Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

fix: webmanifest missing crossorigin attribute (#566)

a4bf213

Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

fix: Dict value loses 1 trailing character on UI Launch. (#561)

b6e1e40

fix: dict lose trailing issue Signed-off-by: James <[email protected]> Signed-off-by: James <[email protected]>

fix: launchform validation (#557)

9c2632a

* fix: disable launch button and show validation messaages Signed-off-by: James <[email protected]> * fix: code clean Signed-off-by: James <[email protected]> Signed-off-by: James <[email protected]>

fix: correctly coerce defaultValue when rendering LaunchPlan details (

7e3c6db

#578) fix: correctly coerce defaultValue when rendering LaunchPlan details Signed-off-by: Rahul Mehta <[email protected]> Signed-off-by: Rahul Mehta <[email protected]>

#minor: inputHelpers InputProps (#579)

f027c43

fix: inputHelpers InputProps Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

Pruning some unused packages (#583)

250ab96

Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

feat: minor change (#584)

ce59d55

Minor change Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

fix: floor seconds to int in the edge case moment returns it as float (…

786bced

…#582) Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Olga Nad <[email protected]>

Update Flyteidl version (#575)

9a1ae4c

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

Update Flyteidl version (#590)

64e55be

Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Flyte-Bot <[email protected]> Co-authored-by: flyte-bot <[email protected]>

Launch plan ref v2 (#601)

b9eed42

* progress * Fixed * Removed debug code Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

fix: enable deeplinks in development (#602)

d649546

chore: enable deeplinks in development Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Carina Ursu <[email protected]>

chore: release 1.3.5 (#605)

b9ffd81

Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>

Merge branch 'master' of https://github.com/flyteorg/flyteconsole int…

2139738

…o devmain

jsonporter approved these changes Sep 30, 2022

View reviewed changes

jsonporter merged commit f8cb277 into devmain Sep 30, 2022

jsonporter deleted the olga-union/update-devmain branch September 30, 2022 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge current master into devmain #606

Merge current master into devmain #606

olga-union commented Sep 30, 2022

codecov bot commented Sep 30, 2022

Merge current master into devmain #606

Merge current master into devmain #606

Conversation

olga-union commented Sep 30, 2022

TL;DR

Type

Are all requirements met?

Follow-up issue

codecov bot commented Sep 30, 2022

Codecov Report