Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor flyteconsole #654

Merged
merged 5 commits into from
Jan 19, 2023
Merged

chore: Refactor flyteconsole #654

merged 5 commits into from
Jan 19, 2023

Conversation

ursucarina
Copy link
Contributor

@ursucarina ursucarina commented Dec 16, 2022

TL;DR

Added support for custom console components to be injected into flyteconsole without needing to host the code in the flyteconsole codebase.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Changed the flyteconsole codebase to separate the main console into ./packages that can be imported into custom implementations.
The flyteconsole app will be deployed from ./website.
For contributing to the codebase, all changes should be made to ./packages/console.

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/653

@ursucarina ursucarina requested review from a team, eugenejahn, jsonporter and james-union and removed request for a team December 16, 2022 01:13
@ursucarina ursucarina force-pushed the carina/master branch 3 times, most recently from 195ddbc to 80cbecb Compare December 20, 2022 00:49
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #654 (210adfe) into master (516bbff) will decrease coverage by 0.65%.
The diff coverage is 69.58%.

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
- Coverage   68.28%   67.62%   -0.66%     
==========================================
  Files         449      452       +3     
  Lines       10714    11194     +480     
  Branches     1849     2059     +210     
==========================================
+ Hits         7316     7570     +254     
- Misses       3398     3624     +226     
Impacted Files Coverage Δ
...s/console/src/basics/FeatureFlags/defaultConfig.ts 100.00% <ø> (ø)
...ges/console/src/basics/LocalCache/defaultConfig.ts 100.00% <ø> (ø)
packages/console/src/common/constants.ts 100.00% <ø> (ø)
packages/console/src/common/layout.ts 100.00% <ø> (ø)
packages/console/src/common/promiseUtils.ts 0.00% <0.00%> (ø)
packages/console/src/common/setupProtobuf.ts 0.00% <0.00%> (ø)
packages/console/src/common/timer.ts 0.00% <ø> (ø)
packages/console/src/common/typeCheckers.ts 100.00% <ø> (ø)
packages/console/src/components/App/App.tsx 0.00% <0.00%> (ø)
...kages/console/src/components/Cache/CacheContext.ts 100.00% <ø> (ø)
... and 730 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina merged commit 924bb7e into master Jan 19, 2023
@ursucarina ursucarina deleted the carina/master branch January 19, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor flyteconsole
2 participants