chore: fix expander bug #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carina Ursu <[email protected]>
ursucarina
requested review from
a team,
eugenejahn,
jsonporter and
olga-union
and removed request for
a team
olga-union
reviewed
Feb 2, 2023
Comment on lines
70
to
83
| const expanderContent = React.useMemo(() => { | ||
| return isParentNode(nodeExecution) ? ( | ||
| <RowExpander | ||
| ref={ref as React.ForwardedRef<HTMLButtonElement>} | ||
| key={node.scopedId} | ||
| expanded={isExpanded(node)} | ||
| onClick={() => { | ||
| onToggle(node.id, node.scopedId, nodeLevel); | ||
| }} | ||
| /> | ||
| ) : ( | ||
| <div className={styles.leaf} /> | ||
| ); | ||
| }, [node, nodeLevel]); |
There was a problem hiding this comment.
@ursucarina we need to duplicate this in timeline tab (TaskNames.tsx), or maybe move it to a tiny component which we can use here and in TaskNames
olga-union
reviewed
Feb 2, 2023
packages/console/src/components/Executions/Tables/NodeExecutionsTable.tsx
Show resolved
Hide resolved
jsonporter
approved these changes
Feb 2, 2023
Signed-off-by: Carina Ursu <[email protected]>
jsonporter
pushed a commit
that referenced
this pull request
Feb 14, 2023
* chore: fix expander bug Signed-off-by: Carina Ursu <[email protected]> * chore: add await everywhere Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Jason Porter <[email protected]>
jsonporter
added a commit
that referenced
this pull request
Feb 14, 2023
* fix: execution view children fetch on demand refactor Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Jason Porter <[email protected]> * fix: incorrect import Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Jason Porter <[email protected]> * chore: fix expander bug (#677) * chore: fix expander bug Signed-off-by: Carina Ursu <[email protected]> * chore: add await everywhere Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Jason Porter <[email protected]> * fix: toggle in timeline Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Jason Porter <[email protected]> * fix: checkForDynamicExecutions Signed-off-by: Jason Porter <[email protected]> * Revert "fix: checkForDynamicExecutions" This reverts commit 450d144. Signed-off-by: Jason Porter <[email protected]> * Perf Refactor: Some parent nodes don't load children (#680) fix: checkForDynamicExecutions Signed-off-by: Jason Porter <[email protected]> * chore: simplify graph code Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Jason Porter <[email protected]> * adding util Signed-off-by: Jason Porter <[email protected]> * Changing type Signed-off-by: Jason Porter <[email protected]> * Updated click handlers Signed-off-by: Jason Porter <[email protected]> * Fixed graph dynamic node issue Signed-off-by: Jason Porter <[email protected]> * Key was not a valid prop in this case, removed Signed-off-by: Jason Porter <[email protected]> * chore: fix tests Signed-off-by: Carina Ursu <[email protected]> Signed-off-by: Jason Porter <[email protected]> --------- Signed-off-by: Olga Nad <[email protected]> Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]> Co-authored-by: James <[email protected]> Co-authored-by: james-union <[email protected]> Co-authored-by: Jason Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carina Ursu [email protected]
Read then delete this section
- Make sure to use a concise title for the pull-request.
- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/